[OpenJDK 2D-Dev] RFR: 8186317: Cache font layout tables for use by harfbuzz

srl srl at icu-project.org
Fri Aug 25 22:57:33 UTC 2017


The change looks good to me

On Fri, 25 Aug 2017 13:16:03 -0700, Phil Race <philip.race at oracle.com>
wrote:
> Dmitry commented on what JetBrains are doing but do I have any takers
> to actually  review this change ?
> 
> -phil.
> 
> On 08/16/2017 02:07 PM, Phil Race wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8186317
>> Webrev: http://cr.openjdk.java.net/~prr/8186317/
>>
>> In the ICU code path, we cache the layout tables in native memory so
that
>> when requested by ICU we can just hand the pointer, saving the overhead
>> of copying the Java array for every call to layout.
>>
>> We weren't doing this for harfbuzz and this webrev fixes that.
>>
>> I noticed harfbuzz always retrieves the 'head' table so I decided to 
>> add that to the list of
>> cached tables.
>>
>> The overall result is something like 25-30% performance gain.
>>
>> -phil.

-- 
--
Sent via POST HTTP/1.1


More information about the 2d-dev mailing list