[OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing
Jayathirth D V
jayathirth.d.v at oracle.com
Tue Dec 26 07:48:35 UTC 2017
Hi Brian,
Thanks for your inputs.
I have made changes mentioned by you and will check-in code with your changes.
Please find updated webrev for reference:
http://cr.openjdk.java.net/~jdv/8190997/webrev.03/
Thanks,
Jay
From: Brian Burkhalter
Sent: Wednesday, December 20, 2017 12:59 AM
To: Jayathirth D V
Cc: Sergey Bylokhov; 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing
I concur but you might consider these changes to some verbiage:
* PNGImageReader:
L741 PNG specification -> "The PNG specification"
L744 "PLTE chunk -> "the PLTE chunk"
L749-750 message -> "Required PLTE chunk missing"
* PngPLTEChunkMissingTest
L64 Change message to match PNGImageReader lines 749-750.
Thanks,
Brian
On Dec 18, 2017, at 11:03 PM, Sergey Bylokhov <HYPERLINK "mailto:Sergey.Bylokhov at oracle.com"Sergey.Bylokhov at oracle.com> wrote:
The .02 version looks fine.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20171225/9441ed35/attachment.html>
More information about the 2d-dev
mailing list