[OpenJDK 2D-Dev] <Sound Dev> [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

Alex Menkov alexey.menkov at oracle.com
Fri May 5 21:21:33 UTC 2017


Then +1 to Phil's approval


On 05/05/2017 12:37, Sergey Bylokhov wrote:
> Hi, Alexey.
> Yes it is possible to add </p> to this changes, but actually </p> tag is not used in JavaSound docs. The last one were removed a few years ago. The <p> tag is used in assumption that it affect the text till the next <p> or till the end of the doc.
> So for example in the MidiMessage.java/SizeSequence.java there are a few <p> tags which affects the text till the next <p>, and in this fix just one more <p> was added in the middle.
> ----- alexey.menkov at oracle.com wrote:
>> Overall looks good.
>> One minor point - there are several places when you replace <center>
>> with <p> without end </p>.
>> Usually absent </p> doesn't cause any problem, but it would be better
>> to
>> have end tags for all elements.
>> I see this in
>> src/java.desktop/share/classes/javax/sound/midi/MidiMessage.java
>> src/java.desktop/share/classes/javax/sound/sampled/FloatControl.java
>> src/java.desktop/share/classes/javax/sound/sampled/TargetDataLine.java
>> src/java.desktop/share/classes/javax/swing/SizeSequence.java
>> --alex
>> On 05/04/2017 18:15, Sergey Bylokhov wrote:
>>> Hello,
>>> Please review the fix for jdk9-dev.
>>> This fix is a part of the effort to make all javadoc in jdk9 be
>> compatible to HTML5.
>>> In the fix the most common issues are fixed.
>>> The issues related to tables will be fixed later, because it is
>> depends from the new html styles which are under review[1].
>>> After the fix the number of errors reported during the build in
>> java.desktop module decreased from 300+ to 110.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8179596
>>> Webrev can be found at:
>> http://cr.openjdk.java.net/~serb/8179596/webrev.00
>>> Specdiff: http://cr.openjdk.java.net/~serb/8179596/specdiff.00
>>> [1]
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047433.html

More information about the 2d-dev mailing list