[OpenJDK 2D-Dev] [10] Review request for 8181659: Create an alternative fix for JDK-8167102, whose fix was backed out

Anton Litvinov anton.litvinov at oracle.com
Thu Nov 23 16:54:42 UTC 2017

Hello Prasanta and Phil,

Could you please review the following fix for the bug consisting in 
creation of the alternative version of the fix for 
(https://bugs.openjdk.java.net/browse/JDK-8167102). I am writing to you 
directly, because you reviewed my first fix for this bug, which then 
caused the bug (https://bugs.openjdk.java.net/browse/JDK-8181192) and 
was backed out by the fix for JDK-8181192.

Bug: https://bugs.openjdk.java.net/browse/JDK-8181659
Webrev: http://cr.openjdk.java.net/~alitvinov/8181659/jdk10/webrev.00

This fix is actually the first version of the fix for JDK-8167102 with 
insignificant changes:
- edited comment text;
- 1 redundant check on equality to "null" is removed;
- exclusion of the regression test 
developed for JDK-8167102 is cancelled by removal of "@ignore" tag from 
the test.


1)  The fix is completely OS X specific, because the edited method 
"sun.print.RasterPrinterJob.getPageFormatFromAttributes()" is invoked 
only from the OS X native code in file 

2)  Corrects the behavior of 
"RasterPrinterJob.getPageFormatFromAttributes" method to return a new 
"PageFormat" based on corresponding values of the existing "PageFormat" 
set by the user through 
"java.awt.print.PrinterJob.setPrintable(Printable, PageFormat)", if the 
user does not supply "OrientationRequested", "MediaSizeName", 
"MediaPrintableArea" attributes during the call to 

3) Eliminates the possibility of being blocked during the call 
"Pageable.getPageFormat(int)", like it was with the previous version of 
the fix, because now the fix calls "getPageFormat(int)" only for 
"Pageable" of type "sun.print.OpenBook", which is used by JDK 
especially, when "PageFormat" is the same for all pages of the document, 
when the user calls "PrinterJob.setPrintable(Printable, PageFormat)".

I verified that this fix resolves the original bug JDK-8167102 and does 
not cause the regression JDK-8181192.

Thank you,

More information about the 2d-dev mailing list