[OpenJDK 2D-Dev] <AWT Dev> [10] Review Request: 8182410, 8183508, 8181289

Tue Oct 24 21:56:40 UTC 2017

On 10/24/2017 12:02 PM, Sergey Bylokhov wrote:

> Hi, Semyon
> I guess I did not add a new <a> tags, it seems that this tag is used 
> as an anchor everywhere and since it is allowed in html5 its usage was 
> preserved.
Starting version 9 JDK supports the html5 markup in javadoc, so the 
files need to be updated according to it. In html5 you need <a> only if 
you want to see hyperlink and your fix is modifying those tags.

--Semyon
>
> On 23/10/2017 22:08, Semyon Sadetsky wrote:
>> Hi Sergey,
>>
>> I see no reason to have an extra empty anchor tag to set a bookmark. 
>> The id attribute works with any element.
>>
>> For example:
>>
>>      <a id="Definitions"></a>
>>      <h3>Definitions</h3>
>>
>> should be
>>
>>      <h3 id="Definitions">Definitions</h3>
>>
>> --Semyon
>>
>> On 10/23/2017 02:42 PM, Sergey Bylokhov wrote:
>>>
>>> Hello,
>>> Please review the fix for.
>>> 8182410: missing 'title' in 
>>> api/javax/swing/plaf/synth/doc-files/componentProperties.html
>>> 8183508: multi_tsc.html should be updated
>>> 8181289: Invalid HTML 5 in AWT/Swing docs
>>>
>>> Description:
>>>  - Illegal characters were removed.
>>>  - Unsupported tags/properties were removed -like <tt>, <center>, 
>>> font, etc.(except the tags related to tables which I'll fix later).
>>>  - HTML5 doctype is set for all files.
>>>  - The <title> is set for all files.
>>>  - <a name="" is replaced by <a id=""
>> Why you replace
>>
>>>  - Copyrights were added to some files.
>>>
>>> Note that I placed a <head> tag before copyright to solve errors like:
>>> "A charset attribute on a meta element found after the first 1024 
>>> bytes. Fatal Error: Changing encoding at this point would need 
>>> non-streamable behavior"
>>>
>>> specdiff: 
>>> http://cr.openjdk.java.net/~serb/8181289/specdiff/overview-summary.html
>>>
>>> Bugs:
>>>     https://bugs.openjdk.java.net/browse/JDK-8182410
>>>     https://bugs.openjdk.java.net/browse/JDK-8183508
>>>     https://bugs.openjdk.java.net/browse/JDK-8181289
>>>
>>> Webrev can be found at: 
>>> http://cr.openjdk.java.net/~serb/8181289/webrev.00
>>>
>>
>
>