[OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

[Phil Race]

The fix seems fine but like the other review I wonder if
the test can use a bytearrayoutputstream instead of writing to a file.

-phil.

On 04/11/2018 03:51 AM, Jayathirth D V wrote:
>
> Hello All,
>
> Please review the following fix in JDK11 :
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-6574555
>
> Webrev : http://cr.openjdk.java.net/~jdv/6574555/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ejdv/6574555/webrev.00/>
>
> _Issue:_ PNGImageWriter. write_bKGD() function sets incorrect R, G, B 
> value when IHDR colortype and bKGD colortype is PNG_COLOR_RGB(A).
>
> _Solution:_ Assign values to all channels of RGB as they are present 
> in Metadata instead of using only bKGD red value.
>
> _Note_ : Our default metadata doesn’t set any bKGD chunk but if user 
> specifies bKGD chunk and uses mergeTree() then we check bKGD  R, G, B 
> values and if r == g == b then we store bKGD chunk as of type 
> PNG_COLOR_GRAY.
>
> Thanks,
>
> Jay
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20180411/3b6108d8/attachment.html>