[OpenJDK 2D-Dev] [12] Review Request: 8214076 Cleanup the code related to GraphicsEnvironment/Device/Configuration

Philip Race philip.race at oracle.com
Wed Dec 12 03:23:59 UTC 2018


Looks OK. Please confirm it builds on all platforms + headful + headless 
tests pass on all platforms ..

-phil.

On 11/30/18, 6:21 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 12.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214076
> Webrev: http://cr.openjdk.java.net/~serb/8214076/webrev.01
>
> While I am working on the:
> https://bugs.openjdk.java.net/browse/JDK-8076313
> I have started to unify the code between the platforms, and found
> that the fix became bigger than the small cleanup.
> So I decided to extract it to this separate CR.
>
> Change description:
>  - Unused java/native methods were removed
>  - Name of the variables are unified:
>    1. GConfig will refer GDevice using "device" variable
>    2. GDevice will refer GConfig using "config" variable
>  - @Override is used in all classes
>  - Empty javadoc spec was removed
>  - Most classes were marked as "final" to prove that it is not 
> necessary to
>    update "some other" platform specific subclasses
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20181211/aed6a57a/attachment.html>


More information about the 2d-dev mailing list