[OpenJDK 2D-Dev]  RFR: [JDK-8194489] Incorrect size computation at BandedSampleModel.createDataBuffer
brian.burkhalter at oracle.com
Fri Jan 5 22:51:46 UTC 2018
On Jan 4, 2018, at 9:30 PM, Prahalad Kumar Narayanan <prahalad.kumar.narayanan at oracle.com> wrote:
> Request your time to review the fix for the bug:
> JDK-8194489 Incorrect size computation at BandedSampleModel . createDataBuffer
> Kindly review the changes at your convenience & share your feedback.
> Link: http://cr.openjdk.java.net/~pnarayanan/8194489/webrev.00/
In general I think this looks good. A few comments:
L193-196 and 203-207: In general I think it’s better for method-internal comments to use the “//“ form instead of the “/*…*/“ form.
Instead of defining the utility methods compareSamples(int,int) and initSamples(int,int) you might consider simply using j.u.Arrays.equals(int,int) and j.u.Arrays.fill(int,int), respectively.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev