[OpenJDK 2D-Dev]  RFR JDK-8213051:Invalid use of HTML5 in javax.print files
prasanta.sadhukhan at oracle.com
Fri Nov 30 17:23:49 UTC 2018
Ok. Modified webrev:
On 30-Nov-18 10:12 PM, Alexey Ivanov wrote:
> Hi Prasanta,
> Adding style="text-align: center" attribute to <tbody> element is
> cleaner and achieves the same result as it applies to all <td> (as
> well <th> which are center-aligned by default anyway). If the content
> of the table is modified in the future, there will be no need to add
> style attributes to new cells which will have non-empty content.
> Does it look reasonable?
> On 30/11/2018 15:25, Prasanta Sadhukhan wrote:
>> Hi Alexey,
>> I have modified to keep the "X" centred. Please find the modified
>> On 30-Nov-18 4:50 PM, Alexey Ivanov wrote:
>>> Hi Prasanta,
>>> Would the presentation benefit from
>>> <tbody style="text-align: center">
>>> to keep X centred and thus to preserve the visual appearance?
>>> Do you mind updating the copyright?
>>> Otherwise, the change looks good to me.
>>> On 30/11/2018 07:41, Prasanta Sadhukhan wrote:
>>>> Hi All,
>>>> Please review a doc-fix to comply with HTML5 standard by removing
>>>> the obsolete <td> attribute "align"
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8213051
>>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8213051/webrev.0/
More information about the 2d-dev