[OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

Philip Race philip.race at oracle.com
Sun Mar 10 07:07:39 UTC 2019


+1 (approved)

-phil.

On 3/1/19, 8:58 PM, Martin Balao wrote:
> On 2/27/19 12:20 PM, Philip Race wrote:
>> The webrev still appears to be against jdk/jdk not jdk/client
>>
>> I had suggested excluding small point sizes since I don't think
>> the failures I saw can possibly be limited to Solaris ... it just
>> hasn't been reproduced elsewhere yet.
> Apologies for the misunderstanding.
>
> Webrev.04:
>
>   * http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.04/
>
>   * http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.04.zip
>
> New:
>
>   * Re-enabled Solaris
>
>   * Changed font size to 10px
>
>   * Unnecessary null check removed
>
>   * Rebased against jdk/client
>
> Thanks,
> Martin.-


More information about the 2d-dev mailing list