[OpenJDK 2D-Dev] <Swing Dev> [13] Review Request: 8225372 accessibility errors in tables in java.desktop files

Alexey Ivanov alexey.ivanov at oracle.com
Mon Sep 16 19:09:56 UTC 2019

Hi Sergey,

This version looks good to me.

On 09/09/2019 23:14, Sergey Bylokhov wrote:
> Hi, Alexey.
> Thank you for the review, here is an updated version:
> http://cr.openjdk.java.net/~serb/8225372/webrev.03
>  - GridBagLayout.html: The text about "Figures 1 and 2" was changed
>  - componentProperties.html: The <thead> is added to some of the tables
>  - Modality.html: The <u> was dropped from everywhere, it does not 
> seems to be useful

I think <u> was used to make a term / concept stand out from its 
definition / description.
Anyway, this can be addressed in a separate issue as I mentioned before.
Let's leave it that way for now.

>  - Modality.html: An example block was reworked as suggested:
> http://cr.openjdk.java.net/~serb/8225372/docs.03/api/java.desktop/java/awt/doc-files/Modality.html
> On 9/3/19 10:55 am, Alexey Ivanov wrote:
>> It looks fine to me. And it has more semantic markup.
>> For more visual distinction, we can add style="list-style-type: 
>> circle" to all the nested <ul> elements, or use ‘square’ type. 
>> Alternatively, it's possible to modify the style of the outer <ul> 
>> element, the nested <ul>'s are still rendered with ‘disc’ type.
> They are the same because of CSS style used by the JavaDoc tool(by 
> default nested ul elements are different from the outer elements), I 
> guess we need to file a bug to restore this appearance(if this change 
> was not intentional).

Yeah, I know.
Javadoc tool likely redefines presentation rules to not depend on 
browser defaults and, therefore, to look consistently across different 
browsers. There could be not many nested lists in Java documentation 
comments, so this style could be accidental.


More information about the 2d-dev mailing list