[OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins

Alexey Ivanov alexey.ivanov at oracle.com
Mon Aug 17 20:55:34 UTC 2020


Hi Abhishek,

We're getting closer but some annotations from those I listed in my 
previous email are still missing:

*BMPImageReader.java*

2067                 public Boolean run() {


*JPEGImageReader.java*

954                     protected ImageTypeSpecifier produce() {


*TIFFImageWriter.java*

I also found one more missing @Override:
3687     public Raster getTile(int tileX, int tileY) {


*WBMPImageReader.java*

Shall we also sort the imports? I mean move:
   43 import java.io.IOException;
   44 import java.util.ArrayList;
   45 import java.util.Iterator;
to be after
   33 import java.awt.image.WritableRaster;

Though It's fine with me as is.


Regards,
Alexey

On 12/08/2020 13:30, Kumar Abhishek wrote:
> Hi Alexey,
>
> Thank you for looking into it.
>
> I have updated the code with  below suggestion.
> Please find the updated Webrev:-
> Webrev link : http://cr.openjdk.java.net/~jdv/8200281/webrev.04/
>
>
> Thanks,
> Abhishek
>
> -----Original Message-----
> From: Alexey Ivanov
> Sent: Thursday, August 6, 2020 3:20 AM
> To: Kumar Abhishek <kumar.z.abhishek at oracle.com>
> Cc: Dmitry Markov <dmitry.markov at oracle.com>; Philip Race <philip.race at oracle.com>; 2d-dev <2d-dev at openjdk.java.net>
> Subject: Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins
>
> Hi Abhishek,
>
> *BMPImageReader.java*
>
> <SNIP>
>
> Missing @Override annotation:
> 2045                 public Boolean run() {
>
>
> <SNIP>
>
> *JPEGImageReader.java*
>
> Missing @Override annotation:
>    953                     protected ImageTypeSpecifier produce() {
>
>
> <SNIP>
>
> Regards,
> Alexey


More information about the 2d-dev mailing list