[OpenJDK 2D-Dev] RFR 8239149: Cleanups in SunFontManager.java and TrueTypeFont.java

Langer, Christoph christoph.langer at sap.com
Mon Mar 2 20:07:46 UTC 2020

Hi Phil,

thanks for the review. I pushed to jdk-client: http://hg.openjdk.java.net/jdk/client/rev/5cc32ff976fe

Best regards

From: Phil Race <philip.race at oracle.com>
Sent: Dienstag, 25. Februar 2020 00:49
To: Langer, Christoph <christoph.langer at sap.com>; 2d-dev at openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR 8239149: Cleanups in SunFontManager.java and TrueTypeFont.java

This is OK. I think a lot of the generics were written at a time which pre-dated
the diamond operator in JDK 7.

using sun.security.action - something in java.base is something we should
clean up some day, but you are just changing the way it is referenced and
it is on my clean up list so OK.

Please do push to jdk/client.

On 2/17/20 1:57 AM, Langer, Christoph wrote:

I did some cleanups in src/java.desktop/share/classes/sun/font/SunFontManager.java and src/java.desktop/share/classes/sun/font/TrueTypeFont.java which I’d like to contribute.

Most is about indentation, generics initialization and better usage of AccessController::doPrivileged and friends. Also, some unused imports and locals were removed/commented out.

Please review ��

Bug: https://bugs.openjdk.java.net/browse/JDK-8239149
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8239149.0/

Best regards

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20200302/3f491001/attachment-0001.htm>

More information about the 2d-dev mailing list