[OpenJDK 2D-Dev] RFR: 8241829 Cleanup the code for PrinterJob on windows

Prasanta Sadhukhan prasanta.sadhukhan at oracle.com
Mon Mar 30 14:46:29 UTC 2020

Hi Sergey,

I guess it is better if you directly pass NULL to OpenPrinter, rather 
than create an unnecessary variable.

Also, I think it will be good if we do a ClosePrinter() if 
FindFirstPrinterChangeNotification() fails.

On 30-Mar-20 7:13 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk/client.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8241829
> Fix: http://cr.openjdk.java.net/~serb/8241829/webrev.00
> In PrintServiceLookupProvider.java we always pass NULL to
> the notifyFirstPrinterChange as a name of the printer, so
> we can remove the code which expects a non-null value.

More information about the 2d-dev mailing list