[OpenJDK 2D-Dev] RFR: 8241829 Cleanup the code for PrinterJob on windows

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Mar 31 22:21:45 UTC 2020

Hi, Prasanta.

On 3/30/20 7:46 am, Prasanta Sadhukhan wrote:
> I guess it is better if you directly pass NULL to OpenPrinter, rather than create an unnecessary variable.

That was done only for documentation purposes.

> Also, I think it will be good if we do a ClosePrinter() if FindFirstPrinterChangeNotification() fails.

Nice catch! webrev is updated:

> Regards
> Prasanta
> On 30-Mar-20 7:13 PM, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk/client.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8241829
>> Fix: http://cr.openjdk.java.net/~serb/8241829/webrev.00
>> In PrintServiceLookupProvider.java we always pass NULL to
>> the notifyFirstPrinterChange as a name of the printer, so
>> we can remove the code which expects a non-null value.

Best regards, Sergey.

More information about the 2d-dev mailing list