[OpenJDK 2D-Dev] RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase
jvernee at openjdk.java.net
Thu Sep 10 16:40:57 UTC 2020
On Thu, 10 Sep 2020 15:50:39 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> 14 cc'd mailing lists is unworkable. You need to be subscribed to lists to post, but even if you are a reply-all will
>> be delayed due to all of the mails being held up for moderator approval due to:
>> " Too many recipients to the message"
>> I have a longer email coming once it gets through the moderator approval delay. :(
> Patches that do global replace are always awkward. In this case, there are 150 files changed and most seem to be tests
> or changes to tools used in the build (includes src/hotspot/share/prims/jvmtiEnvFill.java). If these are dropped from
> the patch then it leaves just 43 files, many of which are from 3rd party code that can also be dropped. This should
> reduce the patch down to a manageable 24 or so files that should be trivial to review.
Since one of the motivations for this change is micro benchmark performance, please add a benchmark to the JDKs micro
benchmark suite as well. (see e.g. https://github.com/openjdk/jdk/tree/master/test/micro/org/openjdk/bench/java/lang).
Also, what testing has been done for these changes?
More information about the 2d-dev