[OpenJDK 2D-Dev] RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

David Holmes dholmes at openjdk.java.net
Fri Sep 25 02:26:32 UTC 2020

On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> Please review this small patch to enable the OSX build using Xcode 12.0.
> Thanks,
> Paul

Changes requested by dholmes (Reviewer).

src/hotspot/share/runtime/sharedRuntime.cpp line 2851:

> 2849:     if (buf != NULL) {
> 2850:       CodeBuffer buffer(buf);
> 2851:       short locs_buf[80];

This code is just weird. Why is the buf array not declared to be the desired type? If the compiler rejects double
because it isn't relocInfo* then why does it accept short? And if it accepts short will it accept int or long long or
int64_t? Using int64_t would be a clearer change. Though semantically this code is awful. :( Should it be intptr_t ?


PR: https://git.openjdk.java.net/jdk/pull/348

More information about the 2d-dev mailing list