[OpenJDK 2D-Dev] RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

[Matthias Baesken]

On Tue, 29 Sep 2020 07:11:34 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m line 129:
>> 
>>> 127:     NSColor* result = nil;
>>> 128:
>>> 129:     if (colorIndex < ((useAppleColor) ? sun_lwawt_macosx_LWCToolkit_NUM_APPLE_COLORS :
>>> java_awt_SystemColor_NUM_COLORS)) {
>> 
>> This looks like a plain old bug fix, nothing really to do with the compiler upgrade.  The new compiler presumably just
>> has a new warning that brought attention to the problem.  As such, I don't think it belongs in a PR that's about issues
>> related to the compiler upgrade.  Someone might want to backport just this fix, for example.
>
> Hello  Kim, Paul -  so should we open a separate bug for the
> src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m issue because it might be a general  problem just
> uncovered by the new compiler ? Paul , do you want to do this ? Or should I open a bug and post a separate change for
> the useAppleColor check in CSystemColors.m ?

I created
https://bugs.openjdk.java.net/browse/JDK-8253791
8253791: Issue with useAppleColor check in CSystemColors.m
for this issue (Kim and Paul are fine to have a separate JBS issue for this)

-------------

PR: https://git.openjdk.java.net/jdk/pull/348