[OpenJDK 2D-Dev] RFR: 8271456: Avoid looking up standard charsets in "java.desktop" module [v4]

Sergey Bylokhov serb at openjdk.java.net
Tue Aug 3 23:42:55 UTC 2021


> This is a request to clean up a desktop module as was done in JDK-8233884 for "java.base" module.
> 
> In many places standard charsets are looked up via their names, for example:
> absolutePath.getBytes("UTF-8");
> 
> This could be done more efficiently(x20 time faster) with use of java.nio.charset.StandardCharsets:
> absolutePath.getBytes(StandardCharsets.UTF_8);
> 
> The later variant also makes the code cleaner, as it is known not to throw UnsupportedEncodingException in contrary to the former variant.
> 
> Tested by the desktop headless/headful tests on linux/windows.

Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:

  Update IPPPrintService.java

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4951/files
  - new: https://git.openjdk.java.net/jdk/pull/4951/files/e4e82c83..47ed1e81

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4951&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4951&range=02-03

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4951.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4951/head:pull/4951

PR: https://git.openjdk.java.net/jdk/pull/4951


More information about the 2d-dev mailing list