[OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v5]
prr at openjdk.java.net
Fri Aug 13 19:44:25 UTC 2021
On Fri, 13 Aug 2021 12:27:51 GMT, Maxim Kartashev <github.com+28651297+mkartashev at openjdk.org> wrote:
>> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and `ExceptionClear()` immediately after the Java calls made from the callback function `ReadTTFontFileFunc()` in `freetypeScaler.c`.
>> The exception(s) need to be cleared because we're not returning immediately to Java that would've been able to handle them gracefully. And in order not to loose the exception entirely (even though the return value would also indicate an error condition), print out the exception with `ExceptionDescribe()` to aid in debugging.
> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
> Addressed PR comments
> 1. Optimized imports in the test.
> 2. Got rid of Font.decode().
Marked as reviewed by prr (Reviewer).
More information about the 2d-dev