[OpenJDK 2D-Dev] RFR: 8262446: DragAndDrop hangs on Windows [v2]

Dmitry Markov dmarkov at openjdk.java.net
Fri Mar 5 17:21:37 UTC 2021


On Fri, 5 Mar 2021 17:01:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Dmitry Markov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reuse isInDoDragDropLoop
>
> src/java.desktop/windows/native/libawt/windows/awt_DnDDT.cpp line 228:
> 
>> 226: HRESULT __stdcall AwtDropTarget::DragOver(DWORD grfKeyState, POINTL pt, DWORD __RPC_FAR *pdwEffect) {
>> 227:     TRY;
>> 228:     AwtToolkit::GetInstance().isInDoDragDropLoop = TRUE;
> 
> This is a new addition. Did you miss this function in previous iteration?

Good catch! Actually that line is harmless but it is really unnecessary. I will update PR

-------------

PR: https://git.openjdk.java.net/jdk/pull/2825


More information about the 2d-dev mailing list