[OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v10]

[Sergey Bylokhov]

On Fri, 5 Feb 2021 22:00:54 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Ajit Ghaisas has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 36 additional commits since the last revision:
>> 
>>  - Lanai PR#206 - 8262729 - aghaisas
>>  - Lanai PR#205 - 8262496 - avu
>>  - Lanai PR#203 - 8262313 - jdv
>>  - Lanai PR#202 - 8262293 - avu
>>  - Lanai PR#201 - 8261891 - avu
>>  - Lanai PR#200 - 8262115 - aghaisas
>>  - Merge branch 'master' into 8260931_lanai_JEP_branch
>>  - Lanai PR#199 - 8262091 - aghaisas
>>  - Lanai PR#198 - 8261646 - avu
>>  - Lanai PR#197 - 8261960 - jdv
>>  - ... and 26 more: https://git.openjdk.java.net/jdk/compare/f34bb8ed...5cb1fd91
>
> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m line 82:
> 
>> 80:     (JNIEnv *env, jclass mtlgc)
>> 81: {
>> 82:     FILE *f = popen("/usr/sbin/system_profiler SPDisplaysDataType", "r");
> 
> How robust is this? It seems like the contents of this could be an implementation detail and subject to change. Is it documented by Apple?

I suggest fixing this before the integration.

> test/jdk/performance/client/RenderPerfTest/Makefile line 10:
> 
>> 8: #   - Redistributions of source code must retain the above copyright
>> 9: #     notice, this list of conditions and the following disclaimer.
>> 10: #
> 
> As mentioned in the preliminary review, this file and `build.xml` have a BSD copyright. I think that should be GPLv2 (without classpath exception since this is a test).

Probably place it near J2Dbench?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2403