[OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v10]
avu at openjdk.java.net
Tue Mar 9 22:21:31 UTC 2021
On Mon, 1 Mar 2021 11:17:39 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the Apple Metal API.
>> The entire work on this was done under [OpenJDK Project - Lanai](http://openjdk.java.net/projects/lanai/)
>> We iterated through several Early Access (EA) builds and have reached a stage where it is ready to be integrated to openjdk/jdk. The latest EA build is available at - https://jdk.java.net/lanai/
>> A new option -Dsun.java2d.metal=true | True needs to be used to use this pipeline.
>> **Testing :**
>> This implementation has been tested with the tests present at - [Test Plan for JEP 382: New macOS Rendering Pipeline](https://bugs.openjdk.java.net/browse/JDK-8251396)
>> **Note to reviewers :**
>> 1) Default rendering pipeline on macOS has not been changed by this PR. OpenGL still stays as the default rendering pipeline and Metal rendering pipeline is optional to choose.
>> 2) To apply and test this PR -
>> To enable the metal pipeline you must specify on command line -Dsun.java2d.metal=true (No message will be printed in this case) or -Dsun.java2d.metal=True (A message indicating Metal rendering pipeline is enabled gets printed)
>> 3) Review comments (including some preliminary informal review comments) are tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598
> Ajit Ghaisas has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 36 additional commits since the last revision:
> - Lanai PR#206 - 8262729 - aghaisas
> - Lanai PR#205 - 8262496 - avu
> - Lanai PR#203 - 8262313 - jdv
> - Lanai PR#202 - 8262293 - avu
> - Lanai PR#201 - 8261891 - avu
> - Lanai PR#200 - 8262115 - aghaisas
> - Merge branch 'master' into 8260931_lanai_JEP_branch
> - Lanai PR#199 - 8262091 - aghaisas
> - Lanai PR#198 - 8261646 - avu
> - Lanai PR#197 - 8261960 - jdv
> - ... and 26 more: https://git.openjdk.java.net/jdk/compare/8f9013c3...5cb1fd91
Looks good, but a couple of things should be fixed (JDK-8263325, JDK-8263324)
Changes requested by avu (no project role).
More information about the 2d-dev