[OpenJDK 2D-Dev] RFR: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute [v2]

Alexander Zvegintsev azvegint at openjdk.java.net
Thu Mar 18 18:44:40 UTC 2021


On Thu, 18 Mar 2021 17:30:06 GMT, Phil Race <prr at openjdk.org> wrote:

>> This seems to be a code path that has has not been exercised.
>> We need to check for null values in the array.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8263439: getSupportedAttributeValues() throws NPE for Finishings attribute

Marked as reviewed by azvegint (Reviewer).

src/java.desktop/unix/classes/sun/print/IPPPrintService.java line 572:

> 570:                             (new ExtFinishing(100)).getAll();
> 571:                         for (int j=0; j<fAll.length; j++) {
> 572:                             if (fAll[j] == null) {

Are we still insisting on copyright's year update?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3055


More information about the 2d-dev mailing list