[OpenJDK 2D-Dev] RFR: 8263894: Convert defaultPrinter and printers fields to local variables [v2]

Alexey Ivanov aivanov at openjdk.java.net
Fri Mar 19 21:28:54 UTC 2021


On Fri, 19 Mar 2021 21:05:57 GMT, Phil Race <prr at openjdk.org> wrote:

> Why did you delete the comments ?

The comments highlighted the difference between what is stored in `printers` and in `printServices`: _excludes_ vs. _includes_ the default printer. However, according to the code, `printers` _included_ the default printer too.

Now there's only `printServices` which contains all print services. I decided the comment didn't have much value now. Yet, upon thinking about it, the comment for `printServices` still provides additional insight: the array also contains the `defaultPrintService`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3095


More information about the 2d-dev mailing list