[OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v24]
aph at openjdk.java.net
Tue Mar 23 09:56:56 UTC 2021
On Fri, 12 Mar 2021 16:32:10 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Anton Kozlov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 105 commits:
>> - Merge commit 'refs/pull/11/head' of https://github.com/AntonKozlov/jdk into jdk-macos
>> - workaround JDK-8262895 by disabling subtest
>> - Fix typo
>> - Rename threadWXSetters.hpp -> threadWXSetters.inline.hpp
>> - JDK-8259937: bsd_aarch64 part
>> - Merge remote-tracking branch 'upstream/jdk/master' into jdk-macos
>> - Fix after JDK-8259539, partially revert preconditions
>> - JDK-8260471: bsd_aarch64 part
>> - JDK-8259539: bsd_aarch64 part
>> - JDK-8257828: bsd_aarch64 part
>> - ... and 95 more: https://git.openjdk.java.net/jdk/compare/a6e34b3d...a72f6834
>> @theRealAph, could you elaborate on what is need to be done for [#2200 (review)](https://github.com/openjdk/jdk/pull/2200#pullrequestreview-600597066).
> I think that what you've got now is fine.
> _Mailing list message from [Andrew Haley](mailto:aph at redhat.com) on [build-dev](mailto:build-dev at openjdk.java.net):_
> On 3/15/21 6:56 PM, Anton Kozlov wrote:
> > On Wed, 10 Mar 2021 11:21:44 GMT, Andrew Haley <aph at openjdk.org> wrote:
> > > > We always check for `R18_RESERVED` with `#if(n)def`, is there any reason to define the value for the macro?
> > >
> > >
> > > Robustness, clarity, maintainability, convention. Why not?
> > I've tried to implement the suggestion, but it pulled more unnecessary changes. It makes the intended way to check the condition less clear (`#ifdef` and not `#if`).
> No, no, no! I am not suggesting you change anything else, just that
> you do not define contentless macros. You might as well define it
> to be something, and true is a reasonable default, that's all. It's
> not terribly important, it's just good practice.
I'm quite prepared to drop this if it's holding up the port. It's a style thing, but it's not critical.
More information about the 2d-dev