[OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v29]
vkempik at openjdk.java.net
Tue Mar 23 13:47:49 UTC 2021
On Tue, 23 Mar 2021 13:26:19 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
>> Build changes still look good. Hope you can get this done now! :)
>> > No, no, no! I am not suggesting you change anything else, just that
>> > you do not define contentless macros. You might as well define it
>> > to be something, and true is a reasonable default, that's all. It's
>> > not terribly important, it's just good practice.
>> I'm quite prepared to drop this if it's holding up the port. It's a style thing, but it's not critical.
> Sorry, I missed your reply.
> R18_RESERVED is also defined in https://github.com/openjdk/jdk/blob/master/make/hotspot/gensrc/GensrcAdlc.gmk#L96. I think changing the value here and there would be slightly out of the scope of this PR, so I would prefer to avoid the suggested change.
> The biggest argument from my side is that the current macro value is consistent with the rest of the macros in this file. For example https://github.com/openjdk/jdk/blob/8c1ab38ee20ed61fefbb64b6a9ee605c52d2cb4e/src/hotspot/cpu/aarch64/globalDefinitions_aarch64.hpp#L35
> and https://github.com/openjdk/jdk/blob/b7b391b2ac4208eabdee4e93acd5b0e364953f94/src/hotspot/share/runtime/mutexLocker.cpp#L137
> But https://github.com/openjdk/jdk/blob/8c1ab38ee20ed61fefbb64b6a9ee605c52d2cb4e/src/hotspot/cpu/aarch64/globalDefinitions_aarch64.hpp#L59
That depends on the will of openjdk11 maintainers to accept this (and few other, like jep-388, as we depend on it) contribution.
> 23 марта 2021 г., в 16:39, drej1 ***@***.***> написал(а):
> So, where are we up to now? Are we done yet?
> we would like to get approval for the final version we have now and then integrate this pr as soon as Mark will target it to jdk17
> Hi there, will this be also supported backwards? To support java11 LTS version?
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <https://github.com/openjdk/jdk/pull/2200#issuecomment-804910300>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQS2KRC6LT7BKA37RMS5I5DTFCKX7ANCNFSM4WO4SQXQ>.
More information about the 2d-dev