<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi, Phil, JIm.<br>
New version of the fix:<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8000629/webrev.08">http://cr.openjdk.java.net/~serb/8000629/webrev.08</a><br>
- Assumption that we should scale all native surfaces was wrong.
In case of managed Bufferedimage we shouldn't scale native
surface, because they are copies 1-1.(CGLSurfaceData.java:60).<br>
- BufferedContext is not always updates current Paint, because it
checks transX/transY from sg2d, which is not maintained in the
scale mode.<br>
Test:
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
FillTexturePaint.java<br>
<br>
Also I found a problem in the sg2d.getTransform(), where
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
invScale does not apply to constrainX/Y.<br>
Test:
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
TransformSetGet.java<br>
<br>
On 4/5/13 10:00 PM, Phil Race wrote:<br>
</div>
<blockquote cite="mid:515F1121.4020107@oracle.com" type="cite">SFAIK
you haven't fixed the problem with TexturePaint I pointed out last
week.
<br>
That needs to be fixed before you push.
<br>
<br>
-phil.
<br>
<br>
On 4/5/2013 9:54 AM, Sergey Bylokhov wrote:
<br>
<blockquote type="cite">Hi, Jim.
<br>
I assume, that you haven't additional comments? Can I consider
you as the second reviewer?
<br>
Note that I plan push it to awt-dev because, my other fixes
depend on it.
<br>
<br>
On 3/26/13 7:33 PM, Sergey Bylokhov wrote:
<br>
<blockquote type="cite">Hello,
<br>
Please review the fix for jdk 8.
<br>
Change adds initial support of hidpi(mostly on 2d side). In
the fix scale was added to the surface data/CGraphicsDevice
/CGLLayer. This scale factor maps virtual coordinates to
physical pixels.
<br>
This change doesn't add support of hidpi to aqua l&f and
doesn't add support of dynamic change of scale factor.
<br>
<br>
Bug:
<a class="moz-txt-link-freetext" href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000629">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000629</a>
<br>
Webrev can be found at:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8000629/webrev.06">http://cr.openjdk.java.net/~serb/8000629/webrev.06</a>
<br>
-- <br>
Best regards, Sergey.
<br>
</blockquote>
<br>
<br>
-- <br>
Best regards, Sergey.
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</body>
</html>