<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">
<pre><span class="changed">Some of these seem to need a CCC eg ..
In AttributeException
public Class<?>[] getUnsupportedAttributes();
</span></pre>
and ...<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~darcy/8042864.0/src/share/classes/javax/print/MimeType.java.sdiff.html">http://cr.openjdk.java.net/~darcy/8042864.0/src/share/classes/javax/print/MimeType.java.sdiff.html</a><br>
<br>
<pre><span class="changed">public Map<String, String> getParameterMap() {
</span></pre>
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~darcy/8042864.0/src/share/classes/javax/print/attribute/standard/DialogTypeSelection.java.sdiff.html">http://cr.openjdk.java.net/~darcy/8042864.0/src/share/classes/javax/print/attribute/standard/DialogTypeSelection.java.sdiff.html</a><br>
<br>
< <span class="changed"> 113 public final Class getCategory()
{<br>
<br>
> </span><span class="changed">113 public final
Class<DialogTypeSelection> getCategory() {</span><span
class="changed"><br>
<br>
<br>
getCategory() is a super-class method ..<br>
<br>
</span>So this seems wrong to me and I think<code> it should look
like this ..</code><br>
<br>
<a class="moz-txt-link-freetext" href="http://docs.oracle.com/javase/8/docs/api/javax/print/attribute/Attribute.html">http://docs.oracle.com/javase/8/docs/api/javax/print/attribute/Attribute.html</a><br>
<code><a
href="http://docs.oracle.com/javase/8/docs/api/java/lang/Class.html"
title="class in java.lang">Class</a><? extends <a
href="http://docs.oracle.com/javase/8/docs/api/javax/print/attribute/Attribute.html"
title="interface in javax.print.attribute">Attribute</a>></code>
<code><span class="memberNameLink"><a
href="http://docs.oracle.com/javase/8/docs/api/javax/print/attribute/Attribute.html#getCategory--">getCategory</a></span>()<br>
<br>
<br>
<br>
<br>
-phil.<br>
</code><br>
On 05/19/2014 09:35 AM, Joe Darcy wrote:<br>
</div>
<blockquote cite="mid:537A32D3.9070302@oracle.com" type="cite">*ping*
<br>
<br>
Any other comments?
<br>
<br>
Thanks,
<br>
<br>
-Joe
<br>
<br>
On 05/15/2014 06:06 PM, Joe Darcy wrote:
<br>
<blockquote type="cite">Hi Henry,
<br>
<br>
On 05/15/2014 03:46 PM, Henry Jen wrote:
<br>
<blockquote type="cite">On 05/15/2014 12:07 PM, Joe Darcy wrote:
<br>
<blockquote type="cite">Hello,
<br>
<br>
Please review these change to fix
<br>
<br>
JDK-8042864 : Fix raw and unchecked warnings in
javax.print
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~darcy/8042864.0/">http://cr.openjdk.java.net/~darcy/8042864.0/</a>
<br>
<br>
Patch below.
<br>
</blockquote>
<br>
Looks good to me, just nit-picking.
<br>
<br>
<blockquote type="cite">
<br>
---
old/src/share/classes/javax/print/PrintServiceLookup.java
2014-05-15
<br>
12:04:20.000000000 -0700
<br>
+++
new/src/share/classes/javax/print/PrintServiceLookup.java
2014-05-15
<br>
12:04:20.000000000 -0700
<br>
@@ -208,7 +207,7 @@
<br>
*/
<br>
public static boolean
registerServiceProvider(PrintServiceLookup
<br>
sp) {
<br>
synchronized (PrintServiceLookup.class) {
<br>
- Iterator psIterator =
getAllLookupServices().iterator();
<br>
+ Iterator<?> psIterator =
getAllLookupServices().iterator();
<br>
while (psIterator.hasNext()) {
<br>
try {
<br>
Object lus = psIterator.next();
<br>
</blockquote>
<br>
We know this is Iterator<PrinterServiceLookup>, but this
works.
<br>
</blockquote>
<br>
I can put the more precise type information in.
<br>
<br>
<blockquote type="cite">
<br>
<blockquote type="cite">---
<br>
old/src/share/classes/javax/print/attribute/AttributeSetUtilities.java
<br>
2014-05-15 12:04:22.000000000 -0700
<br>
+++
<br>
new/src/share/classes/javax/print/attribute/AttributeSetUtilities.java
<br>
2014-05-15 12:04:22.000000000 -0700
<br>
@@ -523,7 +523,7 @@
<br>
public static Class<?>
<br>
verifyAttributeCategory(Object object,
Class<?> interfaceName) {
<br>
<br>
- Class result = (Class) object;
<br>
+ Class<?> result = (Class) object;
<br>
if (interfaceName.isAssignableFrom (result)) {
<br>
return result;
<br>
}
<br>
</blockquote>
<br>
Should the cast be (Class<?>) instead of (Class)?
<br>
</blockquote>
<br>
I think either is okay, but I'm fine to change this to
Class<?>.
<br>
<br>
<blockquote type="cite">
<br>
<blockquote type="cite">---
<br>
old/src/share/classes/javax/print/attribute/standard/DialogTypeSelection.java
<br>
2014-05-15 12:04:24.000000000 -0700
<br>
+++
<br>
new/src/share/classes/javax/print/attribute/standard/DialogTypeSelection.java
<br>
2014-05-15 12:04:23.000000000 -0700
<br>
@@ -110,7 +110,7 @@
<br>
* @return Printing attribute class (category), an
instance of class
<br>
* {@link java.lang.Class java.lang.Class}.
<br>
*/
<br>
- public final Class getCategory() {
<br>
+ public final Class<DialogTypeSelection>
getCategory() {
<br>
return DialogTypeSelection.class;
<br>
}
<br>
<br>
</blockquote>
<br>
Would this be too specific for this public API? <? extends
Attribute> is defined in interface Attribute.
<br>
</blockquote>
<br>
Well, the javadoc does say that DialogTypeSelection.class is
returned. The DialogTypeSelection class does implement the
Attribute interface so all the typing works out fine as-is.
<br>
<br>
<blockquote type="cite">
<br>
<br>
<blockquote type="cite">---
<br>
old/src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java
<br>
2014-05-15 12:04:25.000000000 -0700
<br>
+++
<br>
new/src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java
<br>
2014-05-15 12:04:24.000000000 -0700
<br>
@@ -242,16 +242,18 @@
<br>
extends AbstractSet<PrinterStateReason>
<br>
{
<br>
private Severity mySeverity;
<br>
- private Set myEntrySet;
<br>
+ //
<br>
+ private Set<Map.Entry<PrinterStateReason,
Severity>> myEntrySet;
<br>
<br>
- public PrinterStateReasonSet(Severity severity, Set
entrySet) {
<br>
+ public PrinterStateReasonSet(Severity severity,
<br>
+ Set<Map.Entry<PrinterStateReason, Severity>>
entrySet) {
<br>
mySeverity = severity;
<br>
myEntrySet = entrySet;
<br>
}
<br>
<br>
public int size() {
<br>
int result = 0;
<br>
- Iterator iter = iterator();
<br>
+ Iterator<?> iter = iterator();
<br>
</blockquote>
<br>
We know it is Iterator<PrinterStateReason>.
<br>
<br>
<br>
</blockquote>
<br>
That was less clear when I addressed the warning on that line,
but the exact time works better.
<br>
<br>
Updated webrev uploaded to:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~darcy/8042864.1">http://cr.openjdk.java.net/~darcy/8042864.1</a>
<br>
<br>
Thanks for the review,
<br>
<br>
-Joe
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>