<div dir="ltr"><div>Indeed, for quite some time now I believe we don't *really* need this fallback. While we're refactoring this, it would be nice to see this gone too.<br></div><div><br></div><div>I'm sure Phil has better knowledge here to know for sure though.<br></div><div><br>Cheers,<br></div>Mario<br><div><br><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-02-05 17:52 GMT+01:00 Sergey Bylokhov <span dir="ltr"><<a href="mailto:Sergey.Bylokhov@oracle.com" target="_blank">Sergey.Bylokhov@oracle.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello, Roman, Phil.<br>
The fix looks fine except an absent documentation in new class and InternalError + 80 chars per line.<br>
But I have a question: do we really need this failback?<br>
<br>
527 /* Using the X11 font path to locate font files is now a fallback<br>
528 * useful only if fontconfig failed, or is incomplete. So we could<br>
529 * remove this code completely and the consequences should be rare<br>
530 * and non-fatal. If this happens, then the calling Java code can<br>
531 * be modified to no longer require that the AWT lock (the X11GE)<br>
532 * be initialised prior to calling this code.<br>
533 */<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
<br>
On <a href="tel:04.02.2015%2012" value="+49402201512" target="_blank">04.02.2015 12</a>:33, Roman Kennke wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<a href="http://mail.openjdk.java.net/pipermail/awt-dev/2015-January/008819.html" target="_blank">http://mail.openjdk.java.net/<u></u>pipermail/awt-dev/2015-<u></u>January/008819.html</a><br>
<br>
I got no reply, so I'm sending it here, maybe it's a better fit? ;-)<br>
</blockquote>
font related discussions should go to 2d-dev.<br>
The change looks OK. But test it as much as<br>
you can. The previous re-factoring in JDK7<br>
had a fairly long bug trail.<br>
</blockquote>
Ok. I tested a couple of applications, including Java2Demo, Font2DTest<br>
and some more. They all work fine for me.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- Do submit a bug and mark it noreg-cleanup<br>
</blockquote>
Done:<br>
<a href="https://bugs.openjdk.java.net/browse/JDK-8072436" target="_blank">https://bugs.openjdk.java.net/<u></u>browse/JDK-8072436</a><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- Do get a 2nd reviewer before committing.<br>
</blockquote>
How do I do that? That seems to be the tricky part.. ;-)<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- Do update the (C) in the new file to 2015 since the clock ticked<br>
since you first sent the review.<br>
</blockquote>
Done:<br>
<br>
<a href="http://cr.openjdk.java.net/~rkennke/refactor-x11fm/webrev.01/" target="_blank">http://cr.openjdk.java.net/~<u></u>rkennke/refactor-x11fm/webrev.<u></u>01/</a><br>
<br>
I only updated the (C) of the new file, can I leave the existing<br>
copyrights alone?<br>
<br>
Thanks & best regards,<br>
Roman<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
-phil.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Hello,<br>
<br>
I am currently working on a port of AWT/Java2D to DirectFB (using<br>
Caciocavallo [1] as a porting layer).<br>
<br>
I hit one obstacle that is the X11FontManager. I want to use fontconfig<br>
to work with fonts, but can't use anything X11.<br>
<br>
I refactored X11FontManager and related classes and native code to avoid<br>
calling anything X11 specific. Basically I created a superclass of<br>
X11FontManager called FcFontManager that does all the fontconfig related<br>
stuff, and use that in my backend. The changes should not affect the X11<br>
implementation.<br>
<br>
Can you please review the changes here:<br>
<br>
<a href="http://cr.openjdk.java.net/~rkennke/refactor-x11fm/webrev.00/" target="_blank">http://cr.openjdk.java.net/~<u></u>rkennke/refactor-x11fm/webrev.<u></u>00/</a><br>
<br>
I would like to push this into jdk9-client if you think it's ok.<br>
<br>
Best regards,<br>
Roman<br>
<br>
[1] <a href="http://openjdk.java.net/projects/caciocavallo/" target="_blank">http://openjdk.java.net/<u></u>projects/caciocavallo/</a><br>
<br>
<br>
<br>
</blockquote></blockquote>
<br>
</blockquote>
<br>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
Best regards, Sergey.<br>
<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature">pgp key: <a href="http://subkeys.pgp.net/" target="_blank">http://subkeys.pgp.net/</a> PGP Key ID: 80F240CF<br>Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF<br><br>Java Champion - Blog: <a href="http://neugens.wordpress.com" target="_blank">http://neugens.wordpress.com</a> - Twitter: @neugens<br>Proud GNU Classpath developer: <a href="http://www.classpath.org/" target="_blank">http://www.classpath.org/</a><br>OpenJDK: <a href="http://openjdk.java.net/projects/caciocavallo/" target="_blank">http://openjdk.java.net/projects/caciocavallo/</a><br><br>Please, support open standards:<br><a href="http://endsoftpatents.org/" target="_blank">http://endsoftpatents.org/</a><br></div>
</div>