<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 03/06/2015 03:21 PM, Laurent Bourgès
wrote:<br>
</div>
<blockquote
cite="mid:CAKjRUT5Puupcc31EPb+_70DytP1Nj=jLFUp9nK1h91cnFr_WwQ@mail.gmail.com"
type="cite">
<p dir="ltr">Phil,</p>
<p dir="ltr">> Two more things regarding the test<br>
> 1. It was pointed out that you are using GPL+CP .. tests
just use GPL</p>
<p dir="ltr">You mean I must fix the test file header ?</p>
</blockquote>
<br>
Yes, please.<br>
<br>
<blockquote
cite="mid:CAKjRUT5Puupcc31EPb+_70DytP1Nj=jLFUp9nK1h91cnFr_WwQ@mail.gmail.com"
type="cite">
<p dir="ltr">> 2. There's no @bug tag the test. In fact there's
no bug ID here at all :-)<br>
><br>
> A bug ID is needed in order to push.<br>
> You have a JBS account now so could have created it
yourself .. but<br>
> by the time I remembered that I'd already created it for
you :-<br>
><a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8074587">
https://bugs.openjdk.java.net/browse/JDK-8074587</a><br>
><br>
> But I did assign it to you :-)</p>
<p dir="ltr">You're right, I got it.<br>
It seems it is not affected to the graphics rasterizer project,
isn't it ?</p>
</blockquote>
<br>
You can push to graphics rasterizer of course, and no bug ID is
needed.<br>
But I assume this to be one that we'd want to push sooner rather
than later<br>
to the JDK 9 client forest here :-
<a class="moz-txt-link-freetext" href="http://hg.openjdk.java.net/jdk9/client/jdk">http://hg.openjdk.java.net/jdk9/client/jdk</a><br>
since its not directly related to marlin<br>
<br>
<br>
<br>
<br>
<blockquote
cite="mid:CAKjRUT5Puupcc31EPb+_70DytP1Nj=jLFUp9nK1h91cnFr_WwQ@mail.gmail.com"
type="cite">
<p dir="ltr">I am still not familiar with JBS nor pushing
changes...</p>
<p dir="ltr">I will read again the doc about pushing changesets
... tomorrow as it is late. Could you give some hints ?</p>
</blockquote>
<br>
<br>
Jim or I will have to push it there (jdk9/client) for you of course,
but the more such<br>
fixes you contribute, the sooner we can ask for JDK 9 committer
rights as well.<br>
<br>
<blockquote
cite="mid:CAKjRUT5Puupcc31EPb+_70DytP1Nj=jLFUp9nK1h91cnFr_WwQ@mail.gmail.com"
type="cite">
<p dir="ltr">Do you need another webrev with the correct bug id ?</p>
</blockquote>
<br>
Yes, in order to push it for you, but I'd suggest to hold off to see
if Jim points<br>
out anything first ..<br>
<br>
-phil.<br>
<br>
<blockquote
cite="mid:CAKjRUT5Puupcc31EPb+_70DytP1Nj=jLFUp9nK1h91cnFr_WwQ@mail.gmail.com"
type="cite">
<p dir="ltr">Thanks,<br>
Laurent<br>
</p>
</blockquote>
<br>
</body>
</html>