<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Approved.<br>
<br>
-phil.<br>
<br>
On 11/12/2015 10:23 PM, prasanta sadhukhan wrote:<br>
</div>
<blockquote cite="mid:564581EE.3040803@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
Thanks Phil. I was indeed relying on non-presence of equals method
in PageFormat.<br>
<br>
I have modified the webrev to use equality. Can you please review
?<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8067059/webrev.01/">http://cr.openjdk.java.net/~psadhukhan/8067059/webrev.01/</a><br>
<br>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 11/13/2015 11:35 AM, Philip Race
wrote:<br>
</div>
<blockquote cite="mid:56457DBB.50803@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<br>
<br>
On 11/12/15, 9:52 PM, prasanta sadhukhan wrote:
<blockquote cite="mid:56457A8D.9010104@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
Hi Phil,<br>
<br>
<div class="moz-cite-prefix">On 11/13/2015 12:05 AM, Philip
Race wrote:<br>
</div>
<blockquote cite="mid:5644DBE6.10303@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
Shouldn't this use reference equality ?<br>
</blockquote>
It seems Object.java equals() method does == anyways and it
seems it always better to call equals() than to explicitly
check for ==<br>
Is it not correct? If it is not, I will change it.<br>
</blockquote>
<br>
You are relying on PageFormat not over-riding equals.<br>
It could do so and then the intent of your equals call would be
broken<br>
in the case that updates to the dialog resulted in a new
PageFormat<br>
but with the equal fieids.<br>
<br>
-phil.<br>
<br>
<blockquote cite="mid:56457A8D.9010104@oracle.com" type="cite">
<blockquote cite="mid:5644DBE6.10303@oracle.com" type="cite">
Also the test does a number of wild card imports instead of<br>
the specific classes it needs. And I am not sure why it<br>
is importing java.awt.* anyway ..<br>
<br>
And I find qualifying "java.lang.String" to be unnecessary.<br>
</blockquote>
will update the test.<br>
<br>
Regards<br>
Prasanta<br>
<blockquote cite="mid:5644DBE6.10303@oracle.com" type="cite">
<br>
-phil.<br>
<br>
On 11/3/15, 12:59 AM, prasanta sadhukhan wrote:
<blockquote cite="mid:56387767.7060101@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
Hi All,<br>
<br>
Please review a fix for jdk9.<br>
<br>
Bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8067059">https://bugs.openjdk.java.net/browse/JDK-8067059</a><br>
webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8067059/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/8067059/webrev.00/</a><br>
<br>
The issue was if we "cancel" Printer Job setup dialog
which has been created with DialogSelectionType.NATIVE <br>
it should return "null" as per spec <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://docs.oracle.com/javase/8/docs/api/java/awt/print/PrinterJob.html#pageDialog-javax.print.attribute.PrintRequestAttributeSet">https://docs.oracle.com/javase/8/docs/api/java/awt/print/PrinterJob.html#pageDialog-javax.print.attribute.PrintRequestAttributeSet</a>-<br>
<i>[If the user cancels the dialog, the attributes will
not reflect any changes made by the user, and the return
value will be null.]<br>
<br>
</i>We were returning PageFormat instead. Fixed to return
null in such case. <br>
<br>
Regards<br>
Prasanta<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>