<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span style='color:windowtext'>Hi Prasanta,<o:p></o:p></span></p><p class=MsoNormal><span style='color:windowtext'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:windowtext'>Thanks for suggestion. I have made related changes and updated the Webrev.<o:p></o:p></span></p><p class=MsoNormal><span style='color:windowtext'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:windowtext'>Webrev : <a href="http://cr.openjdk.java.net/~jdv/8041501/webrev.01/"><span style='color:windowtext'>http://cr.openjdk.java.net/~jdv/8041501/webrev.01/</span></a><o:p></o:p></span></p><p class=MsoNormal><span style='color:windowtext'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:windowtext'>Please review.<o:p></o:p></span></p><p class=MsoNormal><span style='color:windowtext'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:windowtext'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='color:windowtext'>Jay<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span style='color:windowtext'> prasanta sadhukhan <br><b>Sent:</b> Monday, November 23, 2015 4:43 PM<br><b>To:</b> Jayathirth D V; 2d-dev@openjdk.java.net<br><b>Cc:</b> Philip Race<br><b>Subject:</b> Re: <OpenJDK 2D-Dev> Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Looks ok to me.<br>But probably you could check for image width &height programmatically instead of hardcoding to 64 in testcode.<br><br>Regards<br>Prasanta<span style='font-size:12.0pt'><o:p></o:p></span></p><div><p class=MsoNormal>On 11/23/2015 4:09 PM, Jayathirth D V wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Hello All,<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal><u>Please review following fix in JDK9:</u><o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Bug : <a href="https://bugs.openjdk.java.net/browse/JDK-8041501">https://bugs.openjdk.java.net/browse/JDK-8041501</a><o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Webrev : <a href="http://cr.openjdk.java.net/%7Ejdv/8041501/webrev.00/">http://cr.openjdk.java.net/~jdv/8041501/webrev.00/</a><o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Issue : Pink discoloration when we read JPEG images without JFIF & EXIF header and having no subsampling.<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Root cause : We are overriding JPEG color space set in IJG library at imageioJPEG.c without checking component ID’s properly when JFIF & EXIF are not there. Decision to change color space is solely done consulting sampling factors.<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Solution : Added extra check to verify component ID’s also before changing color space determined by IJG library when there is no JFIF & EXIF header.<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Thanks,<o:p></o:p></p><p class=MsoNormal>Jay<o:p></o:p></p></blockquote><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman",serif'><o:p> </o:p></span></p></div></body></html>