<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8074843">https://bugs.openjdk.java.net/browse/JDK-8074843</a><br>
Fix: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~prr/8074843/">http://cr.openjdk.java.net/~prr/8074843/</a><br>
<br>
Here's a sampling of the warnings that I think covers most, maybe
all, of the cases<br>
LINUX<br>
mlib_ImageAffine_NN_Bit.c:87:81: error: suggest parentheses around
'-' in operand of '&' [-Werror=parentheses]<br>
res = (res & ~(1 << bit)) | (((srcPixelPtr[X
>> (MLIB_SHIFT + 3)] >> (7 - (X >> MLIB_SHIFT)
& 7)) & 1) <<<br>
^<br>
mlib_ImageAffine_NN_Bit.c:153:81: error: suggest parentheses around
'-' in operand of '&' [-Werror=parentheses]<br>
res = (res & ~(1 << bit)) | (((srcPixelPtr[X
>> (MLIB_SHIFT + 3)] >> (7 - (X >> MLIB_SHIFT)
& 7)) & 1) << bit);<br>
<br>
-----------------<br>
mlib_c_ImageCopy.c: In function 'mlib_c_ImageCopy_s16':<br>
mlib_c_ImageCopy.c:439:5: error: suggest parentheses around
assignment used as truth value [-Werror=parentheses]<br>
STRIP(pdst, psrc, src_width, src_height, mlib_u16);<br>
^<br>
-<br>
MAC ...<br>
<br>
mlib_c_ImageCopy.c:331:5: error: using the result of an assignment
as a condition without parentheses [-Werror,-Wparentheses]<br>
STRIP(pdst, psrc, src_width, src_height, mlib_u8);<br>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
mlib_c_ImageCopy.c:185:11: note: expanded from macro 'STRIP'<br>
if (j = w & 1)
\<br>
~~^~~~~~~<br>
mlib_c_ImageCopy.c:331:5: note: place parentheses around the
assignment to silence this warning\<br>
<br>
---<br>
<br>
<br>
---<br>
SOLARIS<br>
mlib_ImageConv_16ext.c", line 532: statement not reached
(E_STATEMENT_NOT_REACHED) <br>
<br>
This last one was not nice just the ";" was considered a statement<br>
after the {XX; YY; return Z} macro expansion<br>
and turning into "do { {....} } while (0)" did not help since<br>
then it said "loop terminator not reached - other cases we have<br>
like this have at least a condition in the macro.<br>
<br>
-phil.<br>
<span class="overlay-icon aui-icon aui-icon-small aui-iconfont-edit"></span>
</body>
</html>