<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 12/10/2016 4:58 AM, Phil Race wrote:<br>
</div>
<blockquote
cite="mid:06b1dd80-c128-4eeb-ae58-2ede9badf60c@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<pre><span class="new">
Regarding being hard-coded for "Selection", the point there is that in the AWT code path
we always generate Postscript, whereas in the 2D path we may send some other content.
</span><span class="new"><span class="new">Since we generate Postscript my instinct here is that Collate should always work since
that gets embedded in the Postscript.
The CUPS filter should then do whatever is necessary to generate the right number
of collated or uncollated copies for the printer.
</span></span><span class="new"><span class="new"><span class="new">
I tracked down the changeset that has the code you reference
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/dead66347eca">http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/dead66347eca</a>
If you read the bug report for that : <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8016737">https://bugs.openjdk.java.net/browse/JDK-8016737</a>
then it becomes clear (sort of) that this was a workaround for the oddity that Collate
worked on Ubuntu 12.04 but not on Ubuntu 13.04, so the idea was to stop saying it
was supported.
That is very annoying of course and I'd love to know if we've rechecked from the source that
"</span></span></span><span class="new"><span class="new"><span class="new">CUPS does not report collate as a supported attribute"</span></span></span></pre>
</blockquote>
I checked getAttMap (response received from cups)<br>
<a class="moz-txt-link-freetext" href="http://hg.openjdk.java.net/jdk9/client/jdk/file/dc658d7dde90/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1767">http://hg.openjdk.java.net/jdk9/client/jdk/file/dc658d7dde90/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1767</a><br>
and there is no "collate-supported" attribute in there.<br>
<blockquote
cite="mid:06b1dd80-c128-4eeb-ae58-2ede9badf60c@oracle.com"
type="cite">
<pre><span class="new"><span class="new"><span class="new">
It is mentioned in CUPS docs.
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://opensource.apple.com/source/cups/cups-62/doc/spm.shtml?txt#CONSTANTS">https://opensource.apple.com/source/cups/cups-62/doc/spm.shtml?txt#CONSTANTS</a>
</span></span>
Also the fix you are proposing doesn't seem to change anything that will help
the test. It expects Collate to be checked. Doesn't it ?
</span></pre>
</blockquote>
The fix does not directly help the test. The idea is to have the
test call first isAttributeCategorySupprted(SheetCollate.class) and
only execute the test if it is supported. It is mentioned inthe bug
report.<br>
Since, now our code returns false for SheetCollate attribute, my fix
will disable the collate option to prevent anomaly of returning
false for support but enabling the collate option.<br>
<br>
Regards<br>
Prasanta<br>
<blockquote
cite="mid:06b1dd80-c128-4eeb-ae58-2ede9badf60c@oracle.com"
type="cite">
<pre><span class="new">
-phil.
</span></pre>
<br>
<br>
<div class="moz-cite-prefix">On 12/09/2016 12:22 AM, Prasanta
Sadhukhan wrote:<br>
</div>
<blockquote
cite="mid:cf5c7acd-b269-07c9-f828-9020ca73fe40@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<p>Hi All,</p>
<p>In continuation with the below mail, the issue is "collate"
option is not checked for linux.</p>
<p>Bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8170352">https://bugs.openjdk.java.net/browse/JDK-8170352</a></p>
<p>webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8170352/webrev.00/">http://cr.openjdk.java.net/~psadhukhan/8170352/webrev.00/</a><br>
</p>
<p>Proposed fix is to disable collate option for linux in
printer dialog.<br>
</p>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 12/8/2016 4:23 PM, Prasanta
Sadhukhan wrote:<br>
</div>
<blockquote
cite="mid:beb05a66-bf2d-ff16-47a8-291688670489@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<p>Hi Phil,</p>
<p>I was investigating JDK-8170352: The collate option is not
checked and I found that CUPS does not report collate as
supported attribute. <br>
</p>
It is removed from printRequestAttrib [<a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l167">http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l167</a>]<br>
so we do not look for collate-supported attribute in CUPS.
Infact, getAttMap does not have any "collate-supported"
attribute too!!<br>
Also, this code [<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1062">http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1062</a>]
has been added [for 8016737] <br>
to remove SheetCollate from supported attributes.<br>
<br>
In light of this, I think we should disabled collate option
from our print dialog even for Toolkit based PrintJob. It
seems, from this code <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l1251">http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l1251</a><br>
it is enabled if we specify in testcase<br>
<i>job.setDefaultSelection(JobAttributes.DefaultSelectionType.SELECTION);
</i>in which case isAWT set to true.<br>
even though selection is determined by attribute support [<a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l1320">http://hg.openjdk.java.net/jdk9/client/jdk/file/a21bac70753d/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l1320</a>]<br>
<br>
I could not find why it is hardcoded to setEnabled(true) for
"Selection". Do you know? mercurial history shows that line
from jdk7 and I could not find previous history.<br>
I think there also, we should check for "<span id="l1320">scSupported"
to enable sheetcollate? Anyways, "Selection" option is not
there in linux.<br>
Please let me know your views.<br>
</span><br>
Regards<br>
Prasanta<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>