<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Thanks, looks good.</p>
<p>/Erik<br>
</p>
<br>
<div class="moz-cite-prefix">On 2016-12-26 16:06, Sergey Bylokhov
wrote:<br>
</div>
<blockquote
cite="mid:9296ED65-E014-4D29-97E2-DC832D69AA36@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
If there are no objections I’ll push this version:
<div class=""><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eserb/8140266/webrev.01/make/lib/Awt2dLibraries.gmk.sdiff.html"
class="">http://cr.openjdk.java.net/~serb/8140266/webrev.01/make/lib/Awt2dLibraries.gmk.sdiff.html</a></div>
<div class=""><br class="">
<div>
<blockquote type="cite" class=""><br
class="Apple-interchange-newline">
<div class="">
<div class="">Build change looks ok, but I too think a
comment explaining why is a good idea.<br class="">
<br class="">
/Erik<br class="">
<br class="">
<br class="">
On 2016-12-23 15:49, Philip Race wrote:<br class="">
<blockquote type="cite" class="">Looks OK to me although
it is a very cryptic option so maybe include a comment<br
class="">
that it is for performance with some versions of gcc
...<br class="">
<br class="">
-phil.<br class="">
<br class="">
On 12/23/16, 3:15 AM, Sergey Bylokhov wrote:<br
class="">
<blockquote type="cite" class="">Hello.<br class="">
Please review the small fix for jdk9.<br class="">
The change add an additional gcc option to the
libawt lib to improve some graphics operations: 20%.<br
class="">
<br class="">
This option is a part of -03.<br class="">
<blockquote type="cite" class="">|-fgcse-after-reload|<br
class="">
When -fgcse-after-reload is enabled, a
redundant load elimination<br class="">
pass is performed after reload. The purpose of
this pass is to<br class="">
clean up redundant spilling. <br class="">
</blockquote>
<a moz-do-not-send="true"
href="https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html"
class="">https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html</a><br
class="">
<br class="">
Note that if -03 will be enabled directly via
OPTIMIZATION flag then the performance will not be
improved.<br class="">
<br class="">
Bug:
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8140266">https://bugs.openjdk.java.net/browse/JDK-8140266</a><br
class="">
Webrev can be found at:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8140266/webrev.00">http://cr.openjdk.java.net/~serb/8140266/webrev.00</a><br
class="">
</blockquote>
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br>
</body>
</html>