<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 01/06/2017 12:33 AM, Prasanta
Sadhukhan wrote:<br>
</div>
<blockquote
cite="mid:6a8b0ad4-94ac-83a0-b3f4-569747dbb980@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<p>Hi Phil,<br>
</p>
Looks good to me . One thing is that, the check for<span
class="changed"> platformID != MAC_PLATFORM_ID</span><br>
shouldn't we do the same in initAllNames()?<br>
</blockquote>
<br>
No, I don't think so. initAllNames() is specifically looking for all
the Windows localised names<br>
and in this change the idea is just to find an English name on Mac
.. not to look for others.<br>
<br>
<blockquote
cite="mid:6a8b0ad4-94ac-83a0-b3f4-569747dbb980@oracle.com"
type="cite"> <br>
Also, in the test, I guess we do not need <br>
<pre>33 import java.io.BufferedInputStream;
35 import java.io.FileInputStream;
36 import java.io.InputStream;
37 </pre>
and copyright should be 2017.<br>
<br>
</blockquote>
<br>
Well, I wrote it in 2016 :-) .. I only posted it in 2017.<br>
<br>
Anyway I will make those changes before I push.<br>
<br>
-phil.<br>
<br>
<blockquote
cite="mid:6a8b0ad4-94ac-83a0-b3f4-569747dbb980@oracle.com"
type="cite"> Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 1/5/2017 5:25 AM, Philip Race
wrote:<br>
</div>
<blockquote cite="mid:586D8B8C.4010600@oracle.com" type="cite"> <br>
Bug : <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-6232267">https://bugs.openjdk.java.net/browse/JDK-6232267</a>
<br>
Webrev : <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eprr/6232267/">http://cr.openjdk.java.net/~prr/6232267/</a>
<br>
<br>
Fonts such as "Menlo" on OS X have no Microsoft names <br>
(see <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://www.microsoft.com/typography/otspec/name.htm">https://www.microsoft.com/typography/otspec/name.htm</a>)
<br>
so historically we rejected these. <br>
<br>
Now that we support OS X, this is more of an issue, and <br>
it is possible to run into a case where we fail to parse these
fonts <br>
when they go through the Font.createFont() path, even on OS X. <br>
<br>
This adds that basic support for parsing Apple names so that <br>
we load the font. This support already exists on JavaFX. <br>
<br>
-phil. <br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>