<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Hi Dmitry,<br>
</p>
<p>Any particular reason why in
imageDataProvider_UnholdJavaPixels(), we are not doing <br>
</p>
<p>isdo->pixels = null; which we do in unholdJavaPixels() </p>
since in holdJavaPixels() , we are doing <br>
<pre>967 else if (isdo->pixels == NULL)
968 {
969 isdo->pixels = (Pixel8bit*)((*env)->GetDirectBufferAddress(env, isdo->array));
970 }
</pre>
<div class="moz-cite-prefix">Also, in the test, I guess there's no
point catching Exception and rethrowing RuntimeException since we
are not doing any processing in catch block. We can just add
throws Exception in main() without this catch block and have
try-finally.<br>
Also, I guess we do not follow adding "author" in the new test
anymore. <br>
<br>
Regards<br>
Prasanta<br>
On 1/22/2017 12:35 AM, Dmitry Markov wrote:<br>
</div>
<blockquote
cite="mid:C43DC296-7D01-40F9-93A3-9BF69FED6654@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
Hi Phil,
<div class=""><br class="">
</div>
<div class="">I agree ‘othervm’ is not necessary here. That is
‘copy-paste’ error. </div>
<div class="">Also I updated the part related to the file deletion
based on your suggestion.</div>
<div class="">Please find new webrev here: <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Edmarkov/8163889/webrev.02/"
class="">http://cr.openjdk.java.net/~dmarkov/8163889/webrev.02/</a></div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Dmitry <br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 21 Jan 2017, at 00:24, Philip Race <<a
moz-do-not-send="true"
href="mailto:philip.race@oracle.com" class="">philip.race@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class=""> Hi Dmitry,<br
class="">
<meta http-equiv="content-type" content="text/html;
charset=utf-8" class="">
> 29 * @run main/othervm PrintCrashTest<br class="">
<pre class="">why othervm ?
I don't think that is strictly necessary just because you are using deleteOnExit.
And FWIW I think the test could "more promptly" delete the file anyway after print returns.
-phil.
</pre>
<br class="">
<br class="">
On 1/20/17, 9:36 AM, Dmitry Markov wrote:
<blockquote
cite="mid:C1BB8E44-79B5-40EB-BFAC-CAC1EA4F35B0@oracle.com"
type="cite" class="">
<pre class="" wrap="">Hi Phil, Prasanta,
I have updated the fix as you suggested, (i.e. added the regression test). The new webrev is located at <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Edmarkov/8163889/webrev.01/">http://cr.openjdk.java.net/~dmarkov/8163889/webrev.01/</a>
Could you review the new version, please?
Thanks,
Dmitry
</pre>
<blockquote type="cite" class="">
<pre class="" wrap="">On 20 Jan 2017, at 19:50, Phil Race <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:philip.race@oracle.com"><philip.race@oracle.com></a> wrote:
I haven't looked at the fix (yet) but I definitely agree that a manual regression test
for this is better than none. What else should we do ? Just not test printing ?
In my view which I've expressed to SQE for a really long time, if you aren't testing with
printers installed you aren't testing the whole platform. Whilst it may be convenient
that tests (silently) don't complain when there are no printers, it is a slippery slope ..
-phil.
On 01/20/2017 04:04 AM, Prasanta Sadhukhan wrote:
</pre>
<blockquote type="cite" class="">
<pre class="" wrap="">It is possible to create manual regression test for this problem. Also the test will require some additional set up steps such as printer installation and so on. It seems to me that is overhead for person who runs it. However if you insist on test creation, I will add it.
</pre>
</blockquote>
</blockquote>
</blockquote>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br>
</body>
</html>