<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>I guess there is one more problem in usage of CountDown latch.
Have you seen this test fail with timeout even if you wait for 5
minutes as per your timeout period?<br>
</p>
<p>latch.await() needs to be wait on main thread while the test
needs to be executed in another thread otherwise, pageDialog being
modal the control will not come to latch.await()</p>
<p>Iguess you need to do this.</p>
<p>TestUI test = new TestUI(latch);<br>
Thread T1 = new Thread(test);<br>
T1.start();<br>
</p>
class TestUI implements Runnable {<br>
...<br>
@Override<br>
public void run() {<br>
try {<br>
createUI();<br>
<br>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 6/2/2017 4:00 PM, Shashidhara
Veerabhadraiah wrote:<br>
</div>
<blockquote type="cite"
cite="mid:3267ec4c-45ab-4a39-a620-bc987e1e2064@default">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.new
{mso-style-name:new;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Consolas",serif;
color:black;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi,
I have fixed the comments below and updated the webrev @ <a
href="http://cr.openjdk.java.net/%7Epkbalakr/shashi/6949753/webrev_01/"
moz-do-not-send="true">http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_01/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
and regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Shashi<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"
moz-do-not-send="true"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
Prasanta Sadhukhan <br>
<b>Sent:</b> Friday, June 2, 2017 12:36 PM<br>
<b>To:</b> Shashidhara Veerabhadraiah
<a class="moz-txt-link-rfc2396E" href="mailto:shashidhara.veerabhadraiah@oracle.com"><shashidhara.veerabhadraiah@oracle.com></a>;
<a class="moz-txt-link-abbreviated" href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a><br>
<b>Cc:</b> Philip Race <a class="moz-txt-link-rfc2396E" href="mailto:philip.race@oracle.com"><philip.race@oracle.com></a><br>
<b>Subject:</b> Re: [9]JDK-6949753:[TEST BUG]:
java/awt/print/PageFormat/PDialogTest.java needs update
by removing a infinite loop<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Test fix look ok. Only thing is, you can call getPrinterJob()
once and reutilise instead of calling 3 times and probably
there is no need of creating a function<span class="new">
createNewPrintPageSetup()</span> for it (as it calls 1
method) but it is upto you.<o:p></o:p></p>
<p>Few comments:<o:p></o:p></p>
<p class="MsoNormal">Copyright should have "," after 2017.<br>
I guess createUI() does not have any call that throws
exception so no need to have try-catch block for createUI().<br>
Also, there is no need to catch PrinterException and rethrow
RuntimeException, so you can do away with that try-catch.<br>
Also, you can call disposeUI() in passButton and failButton
actionlistener instead of in main(). Also, there is no need
to do setVisible(false) in disposeUI(), dispose() will take
care of that.<br>
You can throw RuntimeException when test timed out (instead of
just println and later getting test fail exception) which is
different from Test Failed RuntimeException. <br>
<br>
Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 6/1/2017 5:10 PM, Shashidhara
Veerabhadraiah wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre>Hi All,<o:p></o:p></pre>
<pre>Please review a fix for a test bug which contained an infinite loop to test the printer setup dialog's margin attributes retention without the manual step procedure.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>The issue with PDialogTest.java which tests the printer setup dialog's margin attributes retention by having as infinite loop to keep popping up the dialog without a proper exit. The test does not cover the instruction steps necessary to properly test dialog's margin attributes retention.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>The updated test file includes the standard manual test template along with test cases to cover the printer dialog's margin attributes retention feature.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Bug:<o:p></o:p></pre>
<pre><a href="https://bugs.openjdk.java.net/browse/JDK-6949753" moz-do-not-send="true"><https://bugs.openjdk.java.net/browse/JDK-6949753></a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Webrev:<o:p></o:p></pre>
<pre><a href="http://cr.openjdk.java.net/%7Epkbalakr/shashi/6949753/webrev_00/" moz-do-not-send="true"><http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_00/></a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Note : PrintDialog on Mac does not show page margins and hence this test does not run on Mac.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Thanks and regards,<o:p></o:p></pre>
<pre>Shashi<o:p></o:p></pre>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
<br>
</body>
</html>