<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<pre><span class="new"></span></pre>
<pre><span class="new"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">>[Shashi] Yes. I intend to use the default paper object as this is a test related to the cross platform default printer dialog.
> In the modified test file, I have set the size of the physical paper instead of relying it on the default setting which may
> vary as you pointed out, depending on the locale.</span></i></b></span></pre>
<pre><span class="new"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">>Now that we have our own paper object(with a constant paper size) and based on the margin setting(which are const</span></i></b></span><span class="new"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">
> it won’t cause an undesirable behavior like going into negative space.</span></i></b></span><span class="new"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"></span></span><span class="new">
</span>
Sorry, that is not a valid thing to do. The print dialog is free to ignore this
or workaround the incompatibility of that paper with the supported media so your test is not reliable.
And I don't see what the cross platform print dialog has to do with it.
It is, or should be, just as aware of the printer sizes as the native one.
-phil.
</pre>
<br>
<br>
<div class="moz-cite-prefix">On 06/12/2017 03:34 AM, Shashidhara
Veerabhadraiah wrote:<br>
</div>
<blockquote type="cite"
cite="mid:58620d3c-70cc-4355-8057-81cf9fc3c322@default">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.new
{mso-style-name:new;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle24
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle25
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle26
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1781021954;
mso-list-type:hybrid;
mso-list-template-ids:1732818938 67698703 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
Phil, Please see below for the comments:<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">The
updated Webrev is at:<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><a
href="http://cr.openjdk.java.net/%7Eaghaisas/shashi/6949753/webrev_05/"
moz-do-not-send="true">http://cr.openjdk.java.net/~aghaisas/shashi/6949753/webrev_05/</a></span></p>
</div>
</blockquote>
<br>
Modified in what way from the previous version ?<br>
<br>
-phil.<br>
<br>
<blockquote type="cite"
cite="mid:58620d3c-70cc-4355-8057-81cf9fc3c322@default">
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
and regards,<br>
Shashi<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"
moz-do-not-send="true"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
Phil Race <br>
<b>Sent:</b> Saturday, June 10, 2017 3:07 AM<br>
<b>To:</b> Prasanta Sadhukhan
<a class="moz-txt-link-rfc2396E" href="mailto:prasanta.sadhukhan@oracle.com"><prasanta.sadhukhan@oracle.com></a>; Shashidhara
Veerabhadraiah
<a class="moz-txt-link-rfc2396E" href="mailto:shashidhara.veerabhadraiah@oracle.com"><shashidhara.veerabhadraiah@oracle.com></a><br>
<b>Cc:</b> <a class="moz-txt-link-abbreviated" href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: [9]JDK-6949753:[TEST BUG]:
java/awt/print/PageFormat/PDialogTest.java needs update
by removing a infinite loop<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<pre><span class="new">private static void setValuesForPrintPageSetup(PageFormat pageFormat, int</span><o:p></o:p></pre>
<pre><span class="new"> 118 marginValue) throws PrinterException {<o:p></o:p></span></pre>
<pre><span class="new"> 119 Paper paper = new Paper();</span><o:p></o:p></pre>
<pre><span class="new"> double paperHeight = paper.getHeight();</span><o:p></o:p></pre>
<pre><span class="new"> 122 double paperWidth = paper.getWidth();</span><o:p></o:p></pre>
<pre><span class="new"> 123 double paperX = paper.getImageableX();</span><o:p></o:p></pre>
<pre><span class="new"> 124 double paperY = paper.getImageableY();</span><o:p></o:p></pre>
<pre><span class="new"> 125 paper.setImageableArea(paperX * marginValue, paperY * marginValue,</span><o:p></o:p></pre>
<pre><span class="new"> 126 paperWidth - (paperX * 2 * marginValue),</span><o:p></o:p></pre>
<pre><span class="new"> 127 paperHeight - (paperY * 2 * marginValue));<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new"> 105 setValuesForPrintPageSetup(pageFormat, 3);<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">I see you call new Paper() above<o:p></o:p></span></pre>
<pre><span class="new"><a href="https://docs.oracle.com/javase/8/docs/api/java/awt/print/Paper.html#Paper" moz-do-not-send="true">https://docs.oracle.com/javase/8/docs/api/java/awt/print/Paper.html#Paper</a>--<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">Did you really intend to use a default paper instead of getting the one<o:p></o:p></span></pre>
<pre><span class="new">from the pageFormat ? On some label printer your Letter Paper may not<o:p></o:p></span></pre>
<pre><span class="new">even be supported. US (aka NA) Letter is 8.5" wide.<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">Also although it probably will work out OK the maths isn't checking<o:p></o:p></span></pre>
<pre><span class="new">for boundary problems.<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">default margin will be 1" so that's what you'll get for paperX and paperY<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">Using your value of 3 we set the imagable area such that<o:p></o:p></span></pre>
<pre><span class="new">imageable X = 1 * 3 = 3<o:p></o:p></span></pre>
<pre><span class="new">imageableWidth = 8.5 - (1 * 2 *3) = 8.5 - 6 = 2.5;<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">Fortunately that worked out positive .. but it does not seem to be enforced.<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">If we'd used 5 it would be a different story : <o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">ix = 5, iw = 8.5 - ( 1 * 2 * 5) = -1.5<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">The implementation will (should) clamp it to non-negative but it<o:p></o:p></span></pre>
<pre><span class="new">might still be better to have some defensive logic of your own.<o:p></o:p></span></pre>
<pre><span class="new"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">[Shashi] Yes. I intend to use the default paper object as this is a test related to the cross platform default printer dialog. In the modified test file, I have set the size of the physical paper instead of relying it on the default setting which may vary as you pointed out, depending on the locale.<o:p></o:p></span></i></b></span></pre>
<pre><span class="new"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Now that we have our own paper object(with a constant paper size) and based on the margin setting(which are constants), it won’t cause an undesirable behavior like going into negative space.</span></i></b></span><span class="new"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">nit: there's a missing space here<o:p></o:p></span></pre>
<pre><o:p> </o:p></pre>
<pre><span class="new"> 75 } catch(PrinterException e) {<o:p></o:p></span></pre>
<pre><span class="new"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">[Shashi] This is fixed now.</span></i></b></span><span class="new"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">-phil.<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<div>
<p class="MsoNormal">On 06/09/2017 03:27 AM, Prasanta
Sadhukhan wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p>looks good to me.<o:p></o:p></p>
<p class="MsoNormal">Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 6/9/2017 3:49 PM, Shashidhara
Veerabhadraiah wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
All, Please find the updated Webrev with fixes for the
comments @ <a
href="http://cr.openjdk.java.net/%7Epkbalakr/shashi/6949753/webrev_04/"
moz-do-not-send="true">http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_04/</a></span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
and regards,<br>
Shashi</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
Philip Race <br>
<b>Sent:</b> Thursday, June 8, 2017 3:32 AM<br>
<b>To:</b> Prasanta Sadhukhan <a
href="mailto:prasanta.sadhukhan@oracle.com"
moz-do-not-send="true"><prasanta.sadhukhan@oracle.com></a><br>
<b>Cc:</b> Shashidhara Veerabhadraiah <a
href="mailto:shashidhara.veerabhadraiah@oracle.com"
moz-do-not-send="true"><shashidhara.veerabhadraiah@oracle.com></a>;
<a href="mailto:2d-dev@openjdk.java.net"
moz-do-not-send="true">2d-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: [9]JDK-6949753:[TEST BUG]:
java/awt/print/PageFormat/PDialogTest.java needs
update by removing a infinite loop</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">.. and please make sure all lines are
<= 80 chars as per the coding standards.<br>
<br>
-phil.<br>
<br>
On 6/6/17, 11:59 PM, Prasanta Sadhukhan wrote: <o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p>do_test() does not need to be under EDT as it invokes
printer pagedialog and not swing components. Actually,
createUI() needs to be under EDT which has not been
done.<o:p></o:p></p>
<p class="MsoNormal">Also, <o:p></o:p></p>
<pre><span class="new">79 SwingUtilities.invokeAndWait(() -> {</span><o:p></o:p></pre>
<pre><span class="new"> 80 test.disposeUI();</span><o:p></o:p></pre>
<pre><span class="new"> 81 });</span><o:p></o:p></pre>
<pre><span class="new"> 82 }</span><o:p></o:p></pre>
<pre><span class="new">should be called before you throw RuntimeException when test times out . </span><o:p></o:p></pre>
<pre><span class="new">There is no need of calling this after</span><o:p></o:p></pre>
<pre><span class="new">75 if (test.testResult == false) {</span><o:p></o:p></pre>
<pre><span class="new"> 76 throw new RuntimeException("Test Failed.");</span><o:p></o:p></pre>
<pre><span class="new"> 77 }</span><o:p></o:p></pre>
<pre><span class="new">as it has already been called in pass/fail actionlistener.</span><o:p></o:p></pre>
<pre><span class="new"> </span><o:p></o:p></pre>
<pre><span class="new">Also, put a sleep after T1.start() and do_test() otherwise since they are in separate thread, in mycase, pagedialog is displayed before test instructions dialog.</span><o:p></o:p></pre>
<pre><span class="new"> </span><o:p></o:p></pre>
<pre><span class="new">Regards</span><o:p></o:p></pre>
<pre><span class="new">Prasanta</span><o:p></o:p></pre>
<div>
<p class="MsoNormal">On 6/7/2017 11:50 AM, Shashidhara
Veerabhadraiah wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
All,</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">
I have altered the manual test template per the
comments.</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoListParagraph"
style="text-indent:-.25in;mso-list:l0 level1 lfo2"><!--[if !supportLists]--><span
style="mso-list:Ignore">1.<span style="font:7.0pt
"Times New Roman""> </span></span><!--[endif]--><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Have
moved the test instructions window under newly
created thread.</span><o:p></o:p></p>
<p class="MsoListParagraph"
style="text-indent:-.25in;mso-list:l0 level1 lfo2"><!--[if !supportLists]--><span
style="mso-list:Ignore">2.<span style="font:7.0pt
"Times New Roman""> </span></span><!--[endif]--><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Have
moved the print dialog(main test module) under EDT.</span><o:p></o:p></p>
<p class="MsoListParagraph"
style="text-indent:-.25in;mso-list:l0 level1 lfo2"><!--[if !supportLists]--><span
style="mso-list:Ignore">3.<span style="font:7.0pt
"Times New Roman""> </span></span><!--[endif]--><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Timer
management shall be done on the main thread.</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">I
have placed the updated Webrev @ <a
href="http://cr.openjdk.java.net/%7Epkbalakr/shashi/6949753/webrev_03/"
moz-do-not-send="true">http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_03/</a></span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Please
let me know if any comments on it.</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
and regards,</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Shashi</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
Prasanta Sadhukhan <br>
<b>Sent:</b> Tuesday, June 6, 2017 11:52 AM<br>
<b>To:</b> Shashidhara Veerabhadraiah <a
href="mailto:shashidhara.veerabhadraiah@oracle.com"
moz-do-not-send="true"><shashidhara.veerabhadraiah@oracle.com></a>;
<a href="mailto:2d-dev@openjdk.java.net"
moz-do-not-send="true">2d-dev@openjdk.java.net</a><br>
<b>Cc:</b> Philip Race <a
href="mailto:philip.race@oracle.com"
moz-do-not-send="true"><philip.race@oracle.com></a><br>
<b>Subject:</b> Re: [9]JDK-6949753:[TEST BUG]:
java/awt/print/PageFormat/PDialogTest.java needs
update by removing a infinite loop</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p>As I told, pageDialog is modal so latch.await() will
not be called if user does not close the page dialog
or do any interaction. The actual test<o:p></o:p></p>
<pre><span class="new">59 PageFormat pageFormat = new PageFormat();</span><o:p></o:p></pre>
<pre><span class="new"> 60 </span><o:p></o:p></pre>
<pre><span class="new"> 61 createNewPrintPageSetup(pageFormat);</span><o:p></o:p></pre>
<pre><span class="new"> 62 </span><o:p></o:p></pre>
<pre><span class="new"> 63 setValuesForPrintPageSetup(pageFormat, 2);</span><o:p></o:p></pre>
<pre><span class="new"> 64 </span><o:p></o:p></pre>
<pre><span class="new"> 65 createNewPrintPageSetup(pageFormat);</span><o:p></o:p></pre>
<pre><span class="new"> 66 </span><o:p></o:p></pre>
<pre><span class="new"> 67 setValuesForPrintPageSetup(pageFormat, 3);</span><o:p></o:p></pre>
<pre><span class="new"> 68 </span><o:p></o:p></pre>
<pre><span class="new"> 69 createNewPrintPageSetup(pageFormat);</span><o:p></o:p></pre>
<p class="MsoNormal"><br>
should be done in other thread.<br>
<br>
Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 6/6/2017 11:24 AM, Shashidhara
Veerabhadraiah wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">The
manual test template that I received from the team
seems buggy and an older version it seems. I have
modified the same per your inputs and now placed
the updated Webrev at <a
href="http://cr.openjdk.java.net/%7Epkbalakr/shashi/6949753/webrev_02/"
moz-do-not-send="true">http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_02/</a>.</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
and regards,</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Shashi</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
Prasanta Sadhukhan <br>
<b>Sent:</b> Monday, June 5, 2017 12:35 PM<br>
<b>To:</b> Shashidhara Veerabhadraiah <a
href="mailto:shashidhara.veerabhadraiah@oracle.com"
moz-do-not-send="true"><shashidhara.veerabhadraiah@oracle.com></a>;
<a href="mailto:2d-dev@openjdk.java.net"
moz-do-not-send="true">2d-dev@openjdk.java.net</a><br>
<b>Cc:</b> Philip Race <a
href="mailto:philip.race@oracle.com"
moz-do-not-send="true"><philip.race@oracle.com></a><br>
<b>Subject:</b> Re: [9]JDK-6949753:[TEST BUG]:
java/awt/print/PageFormat/PDialogTest.java
needs update by removing a infinite loop</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p>I guess there is one more problem in usage of
CountDown latch. Have you seen this test fail with
timeout even if you wait for 5 minutes as per your
timeout period?<o:p></o:p></p>
<p>latch.await() needs to be wait on main thread while
the test needs to be executed in another thread
otherwise, pageDialog being modal the control will
not come to latch.await()<o:p></o:p></p>
<p>Iguess you need to do this.<o:p></o:p></p>
<p>TestUI test = new TestUI(latch);<br>
Thread T1 = new Thread(test);<br>
T1.start();<o:p></o:p></p>
<p class="MsoNormal">class TestUI implements Runnable
{<br>
...<br>
@Override<br>
public void run() {<br>
try {<br>
createUI();<br>
<br>
Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 6/2/2017 4:00 PM,
Shashidhara Veerabhadraiah wrote:<o:p></o:p></p>
</div>
<blockquote
style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi,
I have fixed the comments below and updated the
webrev @ <a
href="http://cr.openjdk.java.net/%7Epkbalakr/shashi/6949753/webrev_01/"
moz-do-not-send="true">http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_01/</a></span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
and regards,</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Shashi</span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
Prasanta Sadhukhan <br>
<b>Sent:</b> Friday, June 2, 2017 12:36 PM<br>
<b>To:</b> Shashidhara Veerabhadraiah <a
href="mailto:shashidhara.veerabhadraiah@oracle.com"
moz-do-not-send="true"><shashidhara.veerabhadraiah@oracle.com></a>;
<a href="mailto:2d-dev@openjdk.java.net"
moz-do-not-send="true">2d-dev@openjdk.java.net</a><br>
<b>Cc:</b> Philip Race <a
href="mailto:philip.race@oracle.com"
moz-do-not-send="true"><philip.race@oracle.com></a><br>
<b>Subject:</b> Re: [9]JDK-6949753:[TEST
BUG]:
java/awt/print/PageFormat/PDialogTest.java
needs update by removing a infinite loop</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p>Test fix look ok. Only thing is, you can call
getPrinterJob() once and reutilise instead of
calling 3 times and probably there is no need of
creating a function<span class="new">
createNewPrintPageSetup()</span> for it (as it
calls 1 method) but it is upto you.<o:p></o:p></p>
<p>Few comments:<o:p></o:p></p>
<p class="MsoNormal">Copyright should have "," after
2017.<br>
I guess createUI() does not have any call that
throws exception so no need to have try-catch
block for createUI().<br>
Also, there is no need to catch PrinterException
and rethrow RuntimeException, so you can do away
with that try-catch.<br>
Also, you can call disposeUI() in passButton and
failButton actionlistener instead of in main().
Also, there is no need to do setVisible(false) in
disposeUI(), dispose() will take care of that.<br>
You can throw RuntimeException when test timed out
(instead of just println and later getting test
fail exception) which is different from Test
Failed RuntimeException. <br>
<br>
Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 6/1/2017 5:10 PM,
Shashidhara Veerabhadraiah wrote:<o:p></o:p></p>
</div>
<blockquote
style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre>Hi All,<o:p></o:p></pre>
<pre>Please review a fix for a test bug which contained an infinite loop to test the printer setup dialog's margin attributes retention without the manual step procedure.<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>The issue with PDialogTest.java which tests the printer setup dialog's margin attributes retention by having as infinite loop to keep popping up the dialog without a proper exit. The test does not cover the instruction steps necessary to properly test dialog's margin attributes retention.<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>The updated test file includes the standard manual test template along with test cases to cover the printer dialog's margin attributes retention feature.<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>Bug:<o:p></o:p></pre>
<pre><a href="https://bugs.openjdk.java.net/browse/JDK-6949753" moz-do-not-send="true"><https://bugs.openjdk.java.net/browse/JDK-6949753></a><o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>Webrev:<o:p></o:p></pre>
<pre><a href="http://cr.openjdk.java.net/%7Epkbalakr/shashi/6949753/webrev_00/" moz-do-not-send="true"><http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_00/></a><o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>Note : PrintDialog on Mac does not show page margins and hence this test does not run on Mac.<o:p></o:p></pre>
<pre> <o:p></o:p></pre>
<pre>Thanks and regards,<o:p></o:p></pre>
<pre>Shashi<o:p></o:p></pre>
</blockquote>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
<br>
</body>
</html>