<div dir="ltr"><div><div><div><div>Kevin & Phil,<br><br></div>Some news on that issue:<br></div>I successfully managed to finish the Path clipping support in Marlin 0.8.2 (release last week):</div><div><a href="https://github.com/bourgesl/marlin-renderer/releases/tag/v0.8.2">https://github.com/bourgesl/marlin-renderer/releases/tag/v0.8.2</a><br></div><div><br></div><div>I fixed few remaining bugs in either Stroker (1) and in PathClipFilter (2) to have proper & tested clipping in Marlin renderer (2D). It now works perfectly with either NZ or EO winding rules.</div><div><br></div>To ensure detecting any artefact between Clipping Off vs On, I implemented a 'basher' test (as recommended by Jim) that renderers 10 000 random polygons (5 -> 9 -> 50 line segments or mixed with line / quads / cubics) ( whose point coordinates are in [-50 to 150] ) to a 100x100 buffered image with or without clipping enabled (using a system property at runtime). Of course, all output pixels are compared and any pixel difference is considered as a failure.<br></div><div><br></div>The new ShapeClipTests tests all stroke combinations (cap / join / with or without dashes / closed or not / EO or NZ rule) and also fills (closed or not / EO or NZ rule) => 170 tests run OK<br><div><div><div><div><br></div><div>I need some time to synchronize MarlinFX and then with either OpenJDK forrest (new) or OpenJFX10.</div><div>If you want the new automated test (long run ~ 20 minutes), I need some time to refactor it as it uses some code from my MapBench tool and have a standalone test class.<br></div><div><br></div><div>Will you have time to review such (medium) changes in Marlin2D (Phil ?) and / or MarlinFX (Kevin ?) before the deadline (dec 14th) ? <br></div><div>I said 'medium' as the code is quite simple to read but the new CG algorithms to ignore / discard useless path elements are cool but not obvious.<br></div><div><br></div><div>Please tell me if you have time and if you prefer a combined (JDK / JFX) webrev or start with 2D or JFX.</div><div><br></div><div>Cheers,<br></div><div>Laurent<br></div><div><br><div><div class="gmail_extra"><br><div class="gmail_quote">2017-09-07 8:52 GMT+02:00 Laurent Bourgès <span dir="ltr"><<a href="mailto:bourges.laurent@gmail.com" target="_blank">bourges.laurent@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto">Hi Kevin,<div dir="auto"><br></div><div dir="auto">Ok I propose to withdraw or postpone this review after JavaOne where we will be able to discuss in a face to face meeting about Marlin & MarlinFX changes for JDK10.</div><div dir="auto"><br></div><div dir="auto">I hope the 2d / jfx groups have other Graphics Guru to help, as good as Jim Graham.</div><div dir="auto"><br></div><div dir="auto">Cheers,</div><div dir="auto">Laurent</div></div><div class="gmail-HOEnZb"><div class="gmail-h5"><div class="gmail_extra"><br><div class="gmail_quote">Le 6 sept. 2017 16:23, "Kevin Rushforth" <<a href="mailto:kevin.rushforth@oracle.com" target="_blank">kevin.rushforth@oracle.com</a>> a écrit :<br type="attribution"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Laurent,<br>
<br>
Some combination of Phil, Sergey, and I will take a look at this when we can. Perhaps there might be others on these two lists who could lend a helping hand?<br>
<br>
-- Kevin</blockquote></div></div></div></div></blockquote></div></div></div></div></div></div></div></div>