<span style=" font-size:10pt;font-family:sans-serif">Thanks Philip.</span>
<br>
<br><span style=" font-size:10pt;font-family:sans-serif">The whole thing
with PNG_DLL_EXPORT not being defined in png.h or png.c is still confusing
to me</span>
<br><span style=" font-size:10pt;font-family:sans-serif">(pngpriv defines
it), especially since png.h ends up using it post-pre-processing, but I
don't know if </span>
<br><span style=" font-size:10pt;font-family:sans-serif">that would bother
people outside the minority that inspect the pre-processed code.</span>
<br>
<br><span style=" font-size:10pt;font-family:sans-serif">I'll leave this
here as a thought for any committer bothered by this, though I won't be
pushing it.</span>
<br>
<br><span style=" font-size:10pt;font-family:sans-serif">---- png.h ----</span>
<br><span style=" font-size:10pt;font-family:sans-serif">+ #ifndef PNG_DLL_EXPORT</span>
<br><span style=" font-size:10pt;font-family:sans-serif">+ #define PNG_DLL_EXPORT</span>
<br><span style=" font-size:10pt;font-family:sans-serif">+ #endif<br>
<br>
Best Regards<br>
<br>
Adam Farley <br>
</span>
<br>
<br><tt><span style=" font-size:10pt">Philip Race <philip.race@oracle.com>
wrote on 29/05/2018 14:23:21:<br>
<br>
> From: Philip Race <philip.race@oracle.com></span></tt>
<br><tt><span style=" font-size:10pt">> To: Adam Farley8 <adam.farley@uk.ibm.com></span></tt>
<br><tt><span style=" font-size:10pt">> Cc: 2d-dev <2d-dev@openjdk.java.net></span></tt>
<br><tt><span style=" font-size:10pt">> Date: 29/05/2018 14:23</span></tt>
<br><tt><span style=" font-size:10pt">> Subject: Re: [OpenJDK 2D-Dev]
Question about splashscreen lib</span></tt>
<br><tt><span style=" font-size:10pt">> <br>
> So far as I can see it does, just indirectly.<br>
> png.c includes pngpriv.h which includes png.h<br>
> <br>
> Not including the declarations of the exported API in the file that<br>
> defines them would be a problem waiting to happen.<br>
> <br>
> -phil.<br>
> <br>
> On 5/29/18, 3:54 AM, Adam Farley8 wrote: </span></tt>
<br><tt><span style=" font-size:10pt">> Hi All, <br>
> <br>
> Does anyone know why png.c does not include png.h? <br>
> <br>
> This tripped me up recently, and I don't understand why png.c would
<br>
> not include png.h.<br>
> <br>
> Best Regards<br>
> <br>
> Adam Farley <br>
> <br>
> Unless stated otherwise above:<br>
> IBM United Kingdom Limited - Registered in England and Wales with
<br>
> number 741598. <br>
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
PO6 3AU</span></tt><span style=" font-size:10pt;font-family:sans-serif"><br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU<br>
</span>