<div dir="ltr"><div>Thanks, <br></div><div>I pushed: <a href="https://hg.openjdk.java.net/jdk/client/rev/7f55aad34ac4">https://hg.openjdk.java.net/jdk/client/rev/7f55aad34ac4</a></div><div><br></div><div>Laurent<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le mar. 10 sept. 2019 à 07:47, Jayathirth Rao <<a href="mailto:jayathirth.d.v@oracle.com">jayathirth.d.v@oracle.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;">+1.<div><br></div><div>Thanks,</div><div>Jay<br><div><div><br><blockquote type="cite"><div>On 10-Sep-2019, at 3:18 AM, Phil Race <<a href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a>> wrote:</div><br class="gmail-m_5322142676134144948Apple-interchange-newline"><div>
<div bgcolor="#FFFFFF">
Approved.<br>
<br>
-phil.<br>
<br>
<div class="gmail-m_5322142676134144948moz-cite-prefix">On 9/6/19 2:15 PM, Laurent Bourgès
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Hi,</div>
<div><br>
</div>
<div>Please review this bug fix for the Marlin renderer (present
in Pisces code since JDK 6?):</div>
<div>JBS: <a href="https://bugs.openjdk.java.net/browse/JDK-8230728" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8230728</a></div>
<div>webrev: <a href="http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/" target="_blank">http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/</a></div>
<div><br>
</div>
<div>This patch fixes a NaN handling in userSpaceLineWidth()
when the affine transform determinant is negative (flip bit is
ON)</div>
<div><br>
</div>
<div>Changes:</div>
<div>- MarlinR<span>enderingEngine: use
abs(at.getDeterminant()) to ensure positive value before
using sqrt</span></div>
<div><span>- FlipBitTest: new jtreg
test reproducing the original problem drawing a thin ellipse
with a flipped transform<br>
</span></div>
<div><br>
<span></span></div>
<div><span>Cheers,</span></div>
<div><span></span>Laurent</div>
</div>
</blockquote>
<br>
</div>
</div></blockquote></div><br></div></div></div></blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature">-- <br>Laurent Bourgès</div>