<div dir="auto">Hi Phil,<div dir="auto"><br><div dir="auto">Is this fix trivial enough to have only one reviewer ?</div><div dir="auto"><br></div><div dir="auto">So I can push asap.</div><div dir="auto"><br></div><div dir="auto">Laurent</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le lun. 9 sept. 2019 à 23:50, Phil Race <<a href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Approved.<br>
<br>
-phil.<br>
<br>
<div class="m_-3988987423198809335moz-cite-prefix">On 9/6/19 2:15 PM, Laurent Bourgès
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Hi,</div>
<div><br>
</div>
<div>Please review this bug fix for the Marlin renderer (present
in Pisces code since JDK 6?):</div>
<div>JBS: <a href="https://bugs.openjdk.java.net/browse/JDK-8230728" target="_blank" rel="noreferrer">https://bugs.openjdk.java.net/browse/JDK-8230728</a></div>
<div>webrev: <a href="http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/" target="_blank" rel="noreferrer">http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/</a></div>
<div><br>
</div>
<div>This patch fixes a NaN handling in userSpaceLineWidth()
when the affine transform determinant is negative (flip bit is
ON)</div>
<div><br>
</div>
<div>Changes:</div>
<div>- MarlinR<span style="color:rgb(0,0,0)">enderingEngine: use
abs(at.getDeterminant()) to ensure positive value before
using sqrt</span></div>
<div><span style="color:rgb(0,0,0)">- FlipBitTest: new jtreg
test reproducing the original problem drawing a thin ellipse
with a flipped transform<br>
</span></div>
<div><br>
<span style="color:rgb(0,0,0)"></span></div>
<div><span style="color:rgb(0,0,0)">Cheers,</span></div>
<div><span style="color:rgb(0,0,0)"></span>Laurent</div>
</div>
</blockquote>
<br>
</div>
</blockquote></div>