<div dir="ltr">Looks good Matthias.<div><br></div><div>While looking at the code I saw that we escape two critical arrays via BufImg_GetRasInfo(). </div><div><br></div><div>I guess its okay if all caller code to GetRasInfo() in the JDK are properly closed with the associated release function; still it made me a bit apprehensive.</div><div><br>Cheers, Thomas</div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Sep 9, 2019 at 4:52 PM Baesken, Matthias <<a href="mailto:matthias.baesken@sap.com">matthias.baesken@sap.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="DE">
<div class="gmail-m_5090618287503636275WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hello, please review the following webrev .<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">I noticed that in function BufImg_SetupICM, in case of initCubemap returning NULL we currently miss a ReleasePrimitiveArrayCritical call;<br>
this should be added.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Bug/webrev :<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><a href="https://bugs.openjdk.java.net/browse/JDK-8230769" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8230769</a><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><a href="http://cr.openjdk.java.net/~mbaesken/webrevs/8230769.0/" target="_blank">http://cr.openjdk.java.net/~mbaesken/webrevs/8230769.0/</a><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks, Matthias<u></u><u></u></p>
</div>
</div>
</blockquote></div>