<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";
mso-fareast-language:DE;}
span.new
{mso-style-name:new;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">+1 (also to remove the variable and use 0.0f in place)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">/Christoph<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE"> 2d-dev <2d-dev-bounces@openjdk.java.net>
<b>On Behalf Of </b>Phil Race<br>
<b>Sent:</b> Donnerstag, 17. Oktober 2019 21:34<br>
<b>To:</b> 2d-dev@openjdk.java.net<br>
<b>Subject:</b> Re: [OpenJDK 2D-Dev] RFR [XS] : 8232381: add result NULL-checking to freetypeScaler.c<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<pre><span class="new">+ jfloat advanceDefault = 0.0f;</span><o:p></o:p></pre>
<pre><span class="new">+ (*env)->SetFloatField(env, metrics, sunFontIDs.xFID, advanceDefault);</span><o:p></o:p></pre>
<pre><span class="new">+ (*env)->SetFloatField(env, metrics, sunFontIDs.yFID, advanceDefault);<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">I don't think we need a variable here. Make it :<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><o:p> </o:p></pre>
<pre><span class="new">+ (*env)->SetFloatField(env, metrics, sunFontIDs.xFID, 0.0f);</span><o:p></o:p></pre>
<pre><span class="new">+ (*env)->SetFloatField(env, metrics, sunFontIDs.yFID, 0.0f);<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">-phil.<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<div>
<p class="MsoNormal">On 10/17/19 12:22 AM, Baesken, Matthias wrote:<span style="mso-fareast-language:DE"><o:p></o:p></span></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span lang="EN-US">Hello, please review the following small webrev .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Java_sun_font_FreetypeFontScaler_getGlyphImageNative might return NULL which should be checked , the change add one missing check .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Bug/webrev :</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><a href="https://bugs.openjdk.java.net/browse/JDK-8232381">https://bugs.openjdk.java.net/browse/JDK-8232381</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><a href="http://cr.openjdk.java.net/~mbaesken/webrevs/8232381.0/">http://cr.openjdk.java.net/~mbaesken/webrevs/8232381.0/</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Thanks and regards, Matthias<o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span style="mso-fareast-language:DE"><o:p> </o:p></span></p>
</div>
</div>
</body>
</html>