<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Theoretically we've been going to fix this fragile test for weeks.<br>
<br>
It tests something important or else I'd ditch it completely ..<br>
<br>
Prasanta ?<br>
<br>
-phil.<br>
<br>
On 10/30/19, 7:14 AM, Langer, Christoph wrote:
<blockquote
cite="mid:AM6PR02MB4801D8105F1B65BE964D794C8A600@AM6PR02MB4801.eurprd02.prod.outlook.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi Matthias,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">looks good, I definitely second that. Let’s
wait what 2d folks (Phil?) have to say.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best regards<o:p></o:p></p>
<p class="MsoNormal">Christoph<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm
0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b>From:</b> Baesken, Matthias
<a class="moz-txt-link-rfc2396E" href="mailto:matthias.baesken@sap.com"><matthias.baesken@sap.com></a> <br>
<b>Sent:</b> Mittwoch, 30. Oktober 2019 14:59<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a><br>
<b>Cc:</b> Langer, Christoph
<a class="moz-txt-link-rfc2396E" href="mailto:christoph.langer@sap.com"><christoph.langer@sap.com></a><br>
<b>Subject:</b> RFR [XS] : 8233202: exclude
javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the following small change
.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">It excludes
javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java
; the test seems to be fragile on various Linux distros ,<o:p></o:p></p>
<p class="MsoNormal"> for instance on our Ubuntu 18 .<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The issues are already described in
detail here :<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="DE"><a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8229935"><span
lang="EN-US">https://bugs.openjdk.java.net/browse/JDK-8229935</span></a><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:35.4pt"><span
lang="DE"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:35.4pt">„All in all
this test looks really fragile. It is a miracle it has
passed as much as it has .. I think Linux<br>
may expose this because the font being used is more or less
"fixed" on the other platforms but<br>
on Linux the font being used varies.”<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">As long as 8229935 is not<span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:#F4F5F7">
fixed, the test should be excluded at least on Linux .<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:#F4F5F7"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:#F4F5F7">Bug/webrev
:<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D;background:#F4F5F7"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="DE"><a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8233202"><span
lang="EN-US">https://bugs.openjdk.java.net/browse/JDK-8233202</span></a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="DE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="DE"><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Embaesken/webrevs/8233202.0/">http://cr.openjdk.java.net/~mbaesken/webrevs/8233202.0/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="DE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="DE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="DE">Thanks, Matthias<o:p></o:p></span></p>
</div>
</div>
</blockquote>
</body>
</html>