<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">I know there was a discussion about this elsewhere but I would like to take the opportunity to correct this now<div class=""><br class=""></div><div class="">make//autoconf/flags-cflags.m4:241</div><div class=""><br class=""></div><div class=""><div class=""><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> elif test "x$TOOLCHAIN_TYPE" = xclang; then</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> if test "x$OPENJDK_TARGET_OS" = xmacosx; then</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> # On MacOSX we optimize for size, something</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> # we should do for all platforms?</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_HIGHEST_JVM="-Os"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_HIGHEST="-Os"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_HI="-Os"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_NORM="-Os"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_DEBUG_JVM=""</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> else</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_HIGHEST_JVM="-O3"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_HIGHEST="-O3"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_HI="-O3"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_NORM="-O2"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_DEBUG_JVM="-O0"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> fi</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_SIZE="-Os"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_DEBUG="-O0"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_NONE="-O0"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> elif test "x$TOOLCHAIN_TYPE" = xxlc; then</span></font></div></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""><br class=""></span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class="">should be changed to </span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""><br class=""></span></font></div><div><div class=""><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> elif test "x$TOOLCHAIN_TYPE" = xclang; then</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_HIGHEST_JVM="-O3"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_HIGHEST="-O3"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_HI="-O3"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_NORM="-O2"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_DEBUG_JVM="-O0"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_SIZE="-Os"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_DEBUG="-O0"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> C_O_FLAG_NONE="-O0"</span></font></div><div class=""><font face="Courier New" class=""><span style="font-style: normal;" class=""> elif test "x$TOOLCHAIN_TYPE" = xxlc; then</span></font></div></div><div class=""><br class=""></div><div class="">MacOSX has been paying a historic and significant performance penalty for no valid reason.</div><div class=""><br class=""></div><div class="">Otherwise +1.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class=""><br class=""></div><div class="">-- Jim</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><blockquote type="cite" class=""><div class="">On Jun 5, 2020, at 4:52 AM, Kim Barrett <<a href="mailto:kim.barrett@oracle.com" class="">kim.barrett@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">[Changes are only to the build system, but since the changes have jdk-wide<br class="">effect I’ve cc’d what I think are the relevant dev lists.]<br class=""><br class="">This change is part of JEP 347; the intent is to target JDK 16.<br class=""><br class="">Please review this change to the building of C++ code in the JDK to<br class="">enable the use of C++14 language features. This change does not make<br class="">any code changes to use new features provided by C++11 or C++14.<br class=""><br class="">This requires trimming the supported compiler versions, moving the<br class="">minimum supported versions forward (significantly, in some cases).<br class="">The new minimums are based on compiler documentation rather than<br class="">testing. It may be that more recent versions are actually required.<br class=""><br class="">This change needs to be tested on platforms not supported by Oracle.<br class="">The JEP test plan includes additional Oracle testing beyond what I’ve done.<br class=""><br class="">CR:<br class=""><a href="https://bugs.openjdk.java.net/browse/JDK-8246032" class="">https://bugs.openjdk.java.net/browse/JDK-8246032</a><br class=""><br class="">Webrev:<br class="">https://cr.openjdk.java.net/~kbarrett/8246032/open.02/<br class=""><br class="">Testing:<br class="">mach5 tier1-5 on Oracle supported platforms.<br class=""><br class="">Performance testing showed no significant changes in either direction.<br class=""><br class="">Build-only (no tests) for linux-arm32, linux-s390x, linux-ppc64le<br class=""><br class=""></div></div></blockquote></div><br class=""></div></body></html>