[aarch64-port-dev ] RFR(M): 8242482: AArch64: Change parameter names of reduction operations to make code clear

[Yang Zhang]

Hi Andrew
Besides tier1, I also test these operations in Vector API test, which can cover all the reduction operations.  

In this directory, there are also some test cases about reduction operations,  which is added in [1].
https://hg.openjdk.java.net/jdk/jdk/file/55c4283a7606/test/hotspot/jtreg/compiler/loopopts/superword

[1] https://bugs.openjdk.java.net/browse/JDK-8240248

Regards
Yang

-----Original Message-----
From: Andrew Haley <aph at redhat.com> 
Sent: Friday, April 17, 2020 4:42 PM
To: Yang Zhang <Yang.Zhang at arm.com>; aarch64-port-dev at openjdk.java.net; hotspot-compiler-dev at openjdk.java.net
Cc: nd <nd at arm.com>
Subject: Re: [aarch64-port-dev ] RFR(M): 8242482: AArch64: Change parameter names of reduction operations to make code clear

On 4/17/20 7:34 AM, Yang Zhang wrote:
> JBS: https://bugs.openjdk.java.net/browse/JDK-8242482
> Webrev: http://cr.openjdk.java.net/~yzhang/8242482/webrev.00/
>
> This patch is a followup patch of previous discussion.
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-April/00
> 8740.html
>
> To make the intent clear, the scalar parameter name is changed to 
> isrc, fsrc or dsrc based on its data type. The vector parameter name is changed to vsrc. And so does temp register.

Thanks, that's much nicer. I haven't been able to check every substitution, though. I'm not quite sure about how to do that.
Is all this stuff covered by our test cases?

--
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671