From forax at univ-mlv.fr Tue Sep 3 13:03:40 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Tue, 3 Sep 2019 15:03:40 +0200 (CEST) Subject: permit with a class which is not a subtype is allowed Message-ID: <1051444176.842173.1567515820517.JavaMail.zimbra@u-pem.fr> The compiler allows to permit a class which is not a subtype. public class AncestorPermitExample { sealed interface I permits A { } final static class A { } } The VM too but it's not a bug for the VM (i believe). R?mi From maurizio.cimadamore at oracle.com Tue Sep 3 13:19:33 2019 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 3 Sep 2019 14:19:33 +0100 Subject: permit with a class which is not a subtype is allowed In-Reply-To: <1051444176.842173.1567515820517.JavaMail.zimbra@u-pem.fr> References: <1051444176.842173.1567515820517.JavaMail.zimbra@u-pem.fr> Message-ID: <809c4cae-b23c-e1f7-f3e8-ce1b0a2a20c6@oracle.com> I think there might be a range of options here - error is one, lint warning (e.g. redundant permits) is another. But, nevertheless you raise a valid point. Maurizio On 03/09/2019 14:03, Remi Forax wrote: > The compiler allows to permit a class which is not a subtype. > > public class AncestorPermitExample { > sealed interface I permits A { > > } > final static class A { > > } > } > > The VM too but it's not a bug for the VM (i believe). > > R?mi From forax at univ-mlv.fr Tue Sep 3 13:31:35 2019 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Tue, 3 Sep 2019 15:31:35 +0200 (CEST) Subject: permit with a class which is not a subtype is allowed In-Reply-To: <809c4cae-b23c-e1f7-f3e8-ce1b0a2a20c6@oracle.com> References: <1051444176.842173.1567515820517.JavaMail.zimbra@u-pem.fr> <809c4cae-b23c-e1f7-f3e8-ce1b0a2a20c6@oracle.com> Message-ID: <1241673845.863244.1567517495461.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "Maurizio Cimadamore" > ?: "Remi Forax" , "amber-dev" > Envoy?: Mardi 3 Septembre 2019 15:19:33 > Objet: Re: permit with a class which is not a subtype is allowed > I think there might be a range of options here - error is one, lint > warning (e.g. redundant permits) is another. I don't see the point of being able to specify a type which is not a subtype given that it will never checked by the VM the VM only check when you load a class that if the parent as a an attribute PermittedSubtypes then the class is among the permitted subtypes. In my opinion, the attribute "PermittedSubtypes" should only store direct subtypes and it should be enforced by the compiler. otherwise you can write some fun stuff like sealed interface I permits J { } sealed interface J permits I { } note that I and J are not related in term of hierarchy. > > But, nevertheless you raise a valid point. > > Maurizio R?mi > > On 03/09/2019 14:03, Remi Forax wrote: >> The compiler allows to permit a class which is not a subtype. >> >> public class AncestorPermitExample { >> sealed interface I permits A { >> >> } >> final static class A { >> >> } >> } >> >> The VM too but it's not a bug for the VM (i believe). >> > > R?mi From vicente.romero at oracle.com Wed Sep 4 16:35:55 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 04 Sep 2019 16:35:55 +0000 Subject: hg: amber/amber: runtime: remove the final flag from sealed types Message-ID: <201909041635.x84GZtuB023665@aojmv0008.oracle.com> Changeset: eb12ef187860 Author: hseigel Date: 2019-09-04 12:35 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/eb12ef187860 runtime: remove the final flag from sealed types ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/java.base/share/classes/java/lang/Class.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! test/hotspot/jtreg/runtime/modules/SealedModuleTest.java ! test/hotspot/jtreg/runtime/sealedTypes/SealedUnnamedModuleTest.java ! test/hotspot/jtreg/runtime/sealedTypes/getPermittedSubtypes.jcod ! test/hotspot/jtreg/runtime/sealedTypes/getPermittedSubtypesTest.java ! test/jdk/java/lang/lang-runtime/RecordTest.java ! test/langtools/tools/javac/sealed/SealedDiffConfigurationsTest.java From maurizio.cimadamore at oracle.com Wed Sep 4 16:41:05 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 04 Sep 2019 16:41:05 +0000 Subject: hg: amber/amber: Automatic merge with records-and-sealed Message-ID: <201909041641.x84Gf5KG029607@aojmv0008.oracle.com> Changeset: 0e2fa14a0ba3 Author: mcimadamore Date: 2019-09-04 16:40 +0000 URL: https://hg.openjdk.java.net/amber/amber/rev/0e2fa14a0ba3 Automatic merge with records-and-sealed From brian.goetz at oracle.com Wed Sep 4 22:35:14 2019 From: brian.goetz at oracle.com (brian.goetz at oracle.com) Date: Wed, 04 Sep 2019 22:35:14 +0000 Subject: hg: amber/amber: More records tests Message-ID: <201909042235.x84MZEMQ028545@aojmv0008.oracle.com> Changeset: 67ce79d04761 Author: briangoetz Date: 2019-09-04 18:34 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/67ce79d04761 More records tests ! test/langtools/tools/javac/records/BadRecord.java ! test/langtools/tools/javac/records/RecordCompilationTests.java ! test/langtools/tools/javac/records/RecordMemberTests.java + test/langtools/tools/javac/records/RecordReflectionTest.java ! test/langtools/tools/javac/records/StaticMembersInInnerClassesTest.java ! test/langtools/tools/javac/records/VarargsRecordsTest.java - test/langtools/tools/javac/records/reflection/RecordReflectionTest.java ! test/langtools/tools/javac/records/writeread/WriteReadTest.java From maurizio.cimadamore at oracle.com Wed Sep 4 22:40:51 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 04 Sep 2019 22:40:51 +0000 Subject: hg: amber/amber: Automatic merge with records-and-sealed Message-ID: <201909042240.x84Mepb6004994@aojmv0008.oracle.com> Changeset: c88abbb43548 Author: mcimadamore Date: 2019-09-04 22:40 +0000 URL: https://hg.openjdk.java.net/amber/amber/rev/c88abbb43548 Automatic merge with records-and-sealed ! test/langtools/tools/javac/records/BadRecord.java ! test/langtools/tools/javac/records/StaticMembersInInnerClassesTest.java - test/langtools/tools/javac/records/reflection/RecordReflectionTest.java ! test/langtools/tools/javac/records/writeread/WriteReadTest.java From vicente.romero at oracle.com Wed Sep 4 23:15:04 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 04 Sep 2019 23:15:04 +0000 Subject: hg: amber/amber: consolidating sealed types tests Message-ID: <201909042315.x84NF4HS024593@aojmv0008.oracle.com> Changeset: fc8b51dff863 Author: vromero Date: 2019-09-04 19:13 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/fc8b51dff863 consolidating sealed types tests ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java - test/langtools/tools/javac/sealed/AnonymousAndLambdaCantExtendSealed.java - test/langtools/tools/javac/sealed/AnonymousAndLambdaCantExtendSealed.out - test/langtools/tools/javac/sealed/NotSealedTest.java - test/langtools/tools/javac/sealed/NotSealedTest.out - test/langtools/tools/javac/sealed/PermitsInNoSealedClass.java - test/langtools/tools/javac/sealed/PermitsInNoSealedClass.out + test/langtools/tools/javac/sealed/SealedCompilationTests.java - test/langtools/tools/javac/sealed/SealedTest01.java - test/langtools/tools/javac/sealed/SealedTest01.out - test/langtools/tools/javac/sealed/SealedTest02.java From maurizio.cimadamore at oracle.com Wed Sep 4 23:21:00 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 04 Sep 2019 23:21:00 +0000 Subject: hg: amber/amber: Automatic merge with records-and-sealed Message-ID: <201909042321.x84NL1SK028613@aojmv0008.oracle.com> Changeset: d45dce240059 Author: mcimadamore Date: 2019-09-04 23:20 +0000 URL: https://hg.openjdk.java.net/amber/amber/rev/d45dce240059 Automatic merge with records-and-sealed - test/langtools/tools/javac/sealed/AnonymousAndLambdaCantExtendSealed.java - test/langtools/tools/javac/sealed/AnonymousAndLambdaCantExtendSealed.out - test/langtools/tools/javac/sealed/NotSealedTest.java - test/langtools/tools/javac/sealed/NotSealedTest.out - test/langtools/tools/javac/sealed/PermitsInNoSealedClass.java - test/langtools/tools/javac/sealed/PermitsInNoSealedClass.out - test/langtools/tools/javac/sealed/SealedTest01.java - test/langtools/tools/javac/sealed/SealedTest01.out - test/langtools/tools/javac/sealed/SealedTest02.java From brandileefehn5 at gmail.com Thu Sep 5 12:03:24 2019 From: brandileefehn5 at gmail.com (Brandi lee Fehn) Date: Thu, 5 Sep 2019 05:03:24 -0700 Subject: No subject Message-ID: Enable JavaScript From jan.lahoda at oracle.com Thu Sep 5 15:37:52 2019 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Thu, 05 Sep 2019 15:37:52 +0000 Subject: hg: amber/amber: 2 new changesets Message-ID: <201909051537.x85FbrKc002588@aojmv0008.oracle.com> Changeset: a7be222931ad Author: jlahoda Date: 2019-09-05 15:58 +0200 URL: https://hg.openjdk.java.net/amber/amber/rev/a7be222931ad Merging patterns-deconstruction branch with the records-and-sealed branch. - src/hotspot/share/oops/recordParamInfo.hpp - src/hotspot/share/oops/recordParamStreams.hpp ! src/java.base/share/classes/java/lang/annotation/ElementType.java - src/java.base/share/classes/java/lang/runtime/Extractor.java - src/java.base/share/classes/java/lang/runtime/ExtractorCarriers.java - src/java.base/share/classes/java/lang/runtime/ExtractorImpl.java + src/java.base/share/classes/java/lang/runtime/PatternCarriers.java + src/java.base/share/classes/java/lang/runtime/PatternHandle.java + src/java.base/share/classes/java/lang/runtime/PatternHandles.java - src/java.base/share/classes/java/lang/runtime/PatternSim.java ! src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java - src/java.base/share/classes/java/lang/runtime/_pattern.java ! src/jdk.compiler/share/classes/com/sun/source/util/TreeScanner.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TypeEnter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeScanner.java - test/jdk/java/lang/extractor/ExtractorTest.java - test/jdk/java/lang/extractor/RecordTest.java - test/jdk/java/lang/extractor/SwitchBootstrapsTest.java - test/jdk/java/lang/extractor/boottest/TEST.properties - test/jdk/java/lang/extractor/boottest/java.base/java/lang/runtime/CarrierTest.java + test/jdk/java/lang/lang-runtime/PatternHandleTest.java + test/jdk/java/lang/lang-runtime/RecordTest.java + test/jdk/java/lang/lang-runtime/SwitchBootstrapsTest.java + test/jdk/java/lang/lang-runtime/boottest/TEST.properties + test/jdk/java/lang/lang-runtime/boottest/java.base/java/lang/runtime/CarrierTest.java ! test/langtools/tools/javac/records/BadRecord.java - test/langtools/tools/javac/records/BadUseOfRecordKeywordTest.java - test/langtools/tools/javac/records/BadUseOfRecordKeywordTest.out + test/langtools/tools/javac/records/OriginTest.java + test/langtools/tools/javac/records/RecordCompilationTests.java + test/langtools/tools/javac/records/RecordMemberTests.java + test/langtools/tools/javac/records/RecordReflectionTest.java + test/langtools/tools/javac/records/StaticMembersInInnerClassesTest.java - test/langtools/tools/javac/records/UserDefinedMethodsTest.java + test/langtools/tools/javac/records/VarargsRecordsTest.java - test/langtools/tools/javac/records/allow_static_fields/AllowStaticFieldsInRecordsTest.java - test/langtools/tools/javac/records/bodyless_interfaces/AllowBodyLessInterfacesTest.java - test/langtools/tools/javac/records/fields/CheckDatumMembersAccess.java - test/langtools/tools/javac/records/fields/DatumCanNotDeclaredFieldsWithSameName.java - test/langtools/tools/javac/records/fields/DatumCanNotDeclaredFieldsWithSameName.out - test/langtools/tools/javac/records/fields/NoAddInstanceFieldsCanBeDeclaredInDatumTest.java - test/langtools/tools/javac/records/fields/NoAddInstanceFieldsCanBeDeclaredInDatumTest.out - test/langtools/tools/javac/records/fields/RecordFieldsTest.java - test/langtools/tools/javac/records/fields/RecordsCantDeclareFieldModifiersTest.java - test/langtools/tools/javac/records/fields/RecordsCantDeclareFieldModifiersTest.out ! test/langtools/tools/javac/records/mandated_members/CheckRecordMembers.java - test/langtools/tools/javac/records/mandated_members/RecordsCanReDeclareMembersTest.java - test/langtools/tools/javac/records/mandated_members/UserDefinedAccessorsMustBePublic.java - test/langtools/tools/javac/records/mandated_members/UserDefinedAccessorsMustBePublic.out - test/langtools/tools/javac/records/mandated_members/canonical_constructor/BadCanonicalConstructorTest.java - test/langtools/tools/javac/records/mandated_members/canonical_constructor/BadCanonicalConstructorTest.out - test/langtools/tools/javac/records/mandated_members/canonical_constructor/CanonicalConstructorTest.java - test/langtools/tools/javac/records/mandated_members/canonical_constructor/MismatchTest.java - test/langtools/tools/javac/records/mandated_members/canonical_constructor/MismatchTest.out - test/langtools/tools/javac/records/mandated_members/canonical_constructor/ParameterLessConstructorsTest.java ! test/langtools/tools/javac/records/mandated_members/read_resolve_method/CheckReadResolveMethodTest.java - test/langtools/tools/javac/records/nested_records_must_be_static_and_final/NestedRecordsMustBeStaticAndFinalTest.java - test/langtools/tools/javac/records/records_cant_be_abstract/RecordsCantBeAbstractTest.java - test/langtools/tools/javac/records/records_cant_be_abstract/RecordsCantBeAbstractTest.out - test/langtools/tools/javac/records/records_cant_have_extends_clause/RecordsCantHaveExtendsClause.java - test/langtools/tools/javac/records/records_cant_have_extends_clause/RecordsCantHaveExtendsClause.out ! test/langtools/tools/javac/records/writeread/WriteReadTest.java - test/langtools/tools/javac/sealed/NotSealedTest.java - test/langtools/tools/javac/sealed/NotSealedTest.out - test/langtools/tools/javac/sealed/SealedTest01.java - test/langtools/tools/javac/sealed/SealedTest01.out - test/langtools/tools/javac/sealed/SealedTest02.java - test/langtools/tools/javac/sealed/separate/TestSeparate_Neg.out Changeset: 8b114c819670 Author: jlahoda Date: 2019-09-05 17:35 +0200 URL: https://hg.openjdk.java.net/amber/amber/rev/8b114c819670 Partial updates for patterns using PatternHandle. ! src/java.base/share/classes/java/lang/runtime/PatternHandles.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TypeEnter.java From vicente.romero at oracle.com Thu Sep 5 18:10:04 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 05 Sep 2019 18:10:04 +0000 Subject: hg: amber/amber: more consolidation of sealed types tests Message-ID: <201909051810.x85IA5AT008237@aojmv0008.oracle.com> Changeset: ca43f98c088c Author: vromero Date: 2019-09-05 14:09 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/ca43f98c088c more consolidation of sealed types tests ! test/langtools/tools/javac/sealed/CheckingAttributeAtRuntimeTest.java - test/langtools/tools/javac/sealed/MethodsOfSealedTypesAreNotFinalByDefaultTest.java ! test/langtools/tools/javac/sealed/SealedCompilationTests.java ! test/langtools/tools/javac/sealed/SealedDiffConfigurationsTest.java ! test/langtools/tools/javac/sealed/sealedExtensionNeg/SealedExtensionNegTest.java - test/langtools/tools/javac/sealed/separate/SealedClasses.java - test/langtools/tools/javac/sealed/separate/TestSeparate01.java - test/langtools/tools/javac/sealed/separate/TestSeparate_Neg.java - test/langtools/tools/javac/sealed/separate/TestSeparate_Neg1.out - test/langtools/tools/javac/sealed/separate/TestSeparate_Neg2.out From maurizio.cimadamore at oracle.com Thu Sep 5 18:47:41 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 05 Sep 2019 18:47:41 +0000 Subject: hg: amber/amber: Automatic merge with records-and-sealed Message-ID: <201909051847.x85Ilgvs028554@aojmv0008.oracle.com> Changeset: 0de36c7c2fe0 Author: mcimadamore Date: 2019-09-05 18:47 +0000 URL: https://hg.openjdk.java.net/amber/amber/rev/0de36c7c2fe0 Automatic merge with records-and-sealed - test/langtools/tools/javac/sealed/MethodsOfSealedTypesAreNotFinalByDefaultTest.java - test/langtools/tools/javac/sealed/separate/SealedClasses.java - test/langtools/tools/javac/sealed/separate/TestSeparate01.java - test/langtools/tools/javac/sealed/separate/TestSeparate_Neg.java - test/langtools/tools/javac/sealed/separate/TestSeparate_Neg1.out - test/langtools/tools/javac/sealed/separate/TestSeparate_Neg2.out From maurizio.cimadamore at oracle.com Thu Sep 5 18:48:11 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 05 Sep 2019 18:48:11 +0000 Subject: hg: amber/amber: Automatic merge with records-and-sealed Message-ID: <201909051848.x85ImBGU029062@aojmv0008.oracle.com> Changeset: 71e01dab5d42 Author: mcimadamore Date: 2019-09-05 18:47 +0000 URL: https://hg.openjdk.java.net/amber/amber/rev/71e01dab5d42 Automatic merge with records-and-sealed - test/langtools/tools/javac/sealed/MethodsOfSealedTypesAreNotFinalByDefaultTest.java - test/langtools/tools/javac/sealed/separate/SealedClasses.java - test/langtools/tools/javac/sealed/separate/TestSeparate01.java - test/langtools/tools/javac/sealed/separate/TestSeparate_Neg.java - test/langtools/tools/javac/sealed/separate/TestSeparate_Neg1.out - test/langtools/tools/javac/sealed/separate/TestSeparate_Neg2.out From maurizio.cimadamore at oracle.com Thu Sep 5 22:34:46 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 05 Sep 2019 22:34:46 +0000 Subject: hg: amber/amber: 742 new changesets Message-ID: <201909052235.x85MZmTG017756@aojmv0008.oracle.com> Changeset: 95794e32352e Author: dlsmith Date: 2019-06-20 14:03 -0600 URL: https://hg.openjdk.java.net/amber/amber/rev/95794e32352e 8226325: Support building of filtered spec bundles Reviewed-by: erikj ! doc/building.md ! make/Docs.gmk ! make/InitSupport.gmk ! make/Main.gmk ! make/data/docs-resources/resources/jdk-default.css Changeset: 0f141453b9e0 Author: lancea Date: 2019-06-20 16:15 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/0f141453b9e0 8226518: Typo in the ConnectionBuilder javadoc examples Reviewed-by: bpb ! src/java.sql/share/classes/java/sql/ConnectionBuilder.java ! src/java.sql/share/classes/javax/sql/PooledConnectionBuilder.java ! src/java.sql/share/classes/javax/sql/XAConnectionBuilder.java Changeset: d3030613fab9 Author: robm Date: 2019-06-20 20:20 +0000 URL: https://hg.openjdk.java.net/amber/amber/rev/d3030613fab9 8223727: com/sun/jndi/ldap/privconn/RunTest.java failed due to hang in LdapRequest.getReplyBer Reviewed-by: prappo ! src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java Changeset: 79a7fc6c9bc7 Author: zgu Date: 2019-06-20 18:29 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/79a7fc6c9bc7 8225590: Shenandoah: Refactor ShenandoahClassLoaderDataRoots API Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp Changeset: e27ae3706392 Author: jwilhelm Date: 2019-06-20 04:08 +0200 URL: https://hg.openjdk.java.net/amber/amber/rev/e27ae3706392 Added tag jdk-13+26 for changeset 0692b67f5462 ! .hgtags Changeset: 1170b6d92d1c Author: xuelei Date: 2019-06-19 21:49 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/1170b6d92d1c 8225766: Curve in certificate should not affect signature scheme when using TLSv1.3 Reviewed-by: ascarpino ! src/java.base/share/classes/sun/security/ssl/SignatureScheme.java ! src/java.base/share/classes/sun/security/ssl/X509Authentication.java + test/jdk/sun/security/ssl/SignatureScheme/Tls13NamedGroups.java Changeset: 65916ade7fa2 Author: erikj Date: 2019-06-20 07:56 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/65916ade7fa2 8226404: bootcycle build uses wrong CDS archive Reviewed-by: iklam ! make/autoconf/bootcycle-spec.gmk.in Changeset: 8892555795cd Author: kvn Date: 2019-06-20 10:32 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/8892555795cd 8223794: applications/kitchensink/Kitchensink.java crash bad oop with Graal Summary: added new nmethod::oop_at_phantom() method for JVMCI to notify GC that oop should be kept alive Reviewed-by: dlong, eosterlund ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/jvmci/jvmciRuntime.cpp ! src/hotspot/share/jvmci/jvmciRuntime.hpp Changeset: 76647c08ce0c Author: epavlova Date: 2019-06-20 11:42 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/76647c08ce0c 8225684: [AOT] vmTestbase/vm/oom/production/AlwaysOOMProduction tests fail with AOTed java.base Reviewed-by: kvn + test/hotspot/jtreg/ProblemList-aot.txt Changeset: de3484367466 Author: jjg Date: 2019-06-20 14:24 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/de3484367466 8226412: Fix command-line help text for javac -target Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties Changeset: ced62a6a7bbe Author: dtitov Date: 2019-06-20 18:47 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/ced62a6a7bbe 8220175: serviceability/dcmd/framework/VMVersionTest.java fails with a timeout Reviewed-by: sspitsyn, cjplummer ! src/hotspot/os/linux/perfMemory_linux.cpp Changeset: 81ac9262e63b Author: jwilhelm Date: 2019-06-21 04:16 +0200 URL: https://hg.openjdk.java.net/amber/amber/rev/81ac9262e63b Merge ! .hgtags Changeset: 00f29fe98900 Author: coffeys Date: 2019-06-21 08:07 +0000 URL: https://hg.openjdk.java.net/amber/amber/rev/00f29fe98900 8133489: Better messaging for PKIX path validation matching Reviewed-by: xuelei ! src/java.base/share/classes/java/security/cert/X509CertSelector.java ! test/jdk/java/security/cert/CertPathBuilder/selfIssued/KeyUsageMatters.java Changeset: 17ba7ce18564 Author: hannesw Date: 2019-06-21 12:23 +0200 URL: https://hg.openjdk.java.net/amber/amber/rev/17ba7ce18564 8225802: Remove unused CSS classes from HTML doclet Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlStyle.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css Changeset: e764228f71dc Author: mullan Date: 2019-06-21 08:38 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/e764228f71dc 8226307: Curve names should be case-insensitive Reviewed-by: igerasim, jnimeh, wetmore ! src/java.base/share/classes/sun/security/util/CurveDB.java ! test/jdk/java/security/KeyAgreement/KeyAgreementTest.java Changeset: 6dfdcd31463d Author: kvn Date: 2019-06-21 13:04 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/6dfdcd31463d 8185139: [Graal] Tests which set too restrictive security manager fail with Graal Summary: tests should also check default policy Reviewed-by: mchung, dfuchs, alanb, mullan ! test/jdk/ProblemList-graal.txt ! test/jdk/java/lang/Class/getDeclaredField/ClassDeclaredFieldsTest.java ! test/jdk/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java ! test/jdk/java/lang/ProcessBuilder/Basic.java ! test/jdk/java/lang/ProcessBuilder/SecurityManagerClinit.java ! test/jdk/java/lang/ProcessHandle/PermissionTest.java ! test/jdk/java/lang/System/Logger/custom/CustomLoggerTest.java ! test/jdk/java/lang/System/Logger/default/DefaultLoggerTest.java ! test/jdk/java/lang/System/LoggerFinder/BaseLoggerFinderTest/BaseLoggerFinderTest.java ! test/jdk/java/lang/System/LoggerFinder/DefaultLoggerFinderTest/DefaultLoggerFinderTest.java ! test/jdk/java/lang/System/LoggerFinder/internal/BaseLoggerBridgeTest/BaseLoggerBridgeTest.java ! test/jdk/java/lang/System/LoggerFinder/internal/BasePlatformLoggerTest/BasePlatformLoggerTest.java ! test/jdk/java/lang/System/LoggerFinder/internal/LoggerBridgeTest/LoggerBridgeTest.java ! test/jdk/java/lang/System/LoggerFinder/internal/PlatformLoggerBridgeTest/PlatformLoggerBridgeTest.java ! test/jdk/java/lang/System/LoggerFinder/jdk/DefaultLoggerBridgeTest/DefaultLoggerBridgeTest.java ! test/jdk/java/lang/System/LoggerFinder/jdk/DefaultPlatformLoggerTest/DefaultPlatformLoggerTest.java ! test/jdk/java/lang/invoke/InvokeDynamicPrintArgs.java ! test/jdk/java/lang/invoke/MethodHandleConstants.java ! test/jdk/java/security/Policy/Dynamic/DynamicPolicy.java ! test/jdk/java/util/concurrent/Executors/PrivilegedCallables.java ! test/jdk/java/util/logging/FileHandlerLongLimit.java ! test/jdk/java/util/logging/FileHandlerPath.java ! test/jdk/java/util/logging/FileHandlerPatternExceptions.java ! test/jdk/java/util/logging/LogManager/Configuration/ParentLoggerWithHandlerGC.java ! test/jdk/java/util/logging/LogManager/Configuration/updateConfiguration/HandlersOnComplexResetUpdate.java ! test/jdk/java/util/logging/LogManager/Configuration/updateConfiguration/HandlersOnComplexUpdate.java ! test/jdk/java/util/logging/LogManager/Configuration/updateConfiguration/SimpleUpdateConfigurationTest.java ! test/jdk/java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java ! test/jdk/java/util/logging/LogManagerAppContextDeadlock.java ! test/jdk/java/util/logging/RootLogger/RootLevelInConfigFile.java ! test/jdk/java/util/logging/TestAppletLoggerContext.java ! test/jdk/java/util/logging/TestConfigurationListeners.java Changeset: 31bf7b93df5d Author: kvn Date: 2019-06-21 16:21 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/31bf7b93df5d 8225810: Update JVMCI Reviewed-by: never, dnsimon ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/jvmci/jvmciEnv.cpp ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCompilationRequest.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java + src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotObjectConstantScope.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaType.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedPrimitiveType.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/IndirectHotSpotObjectConstantImpl.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/SharedLibraryJVMCIReflection.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MetaUtil.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestMetaAccessProvider.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TypeUniverse.java Changeset: a3e3f3caf284 Author: sspitsyn Date: 2019-06-20 23:12 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/a3e3f3caf284 8223736: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java fails due to wrong number of MonitorContendedEntered events Summary: Fix the synchronization issue in the test Reviewed-by: cjplummer, dcubed, amenkov ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/contention/TC04/tc04t001.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/contention/TC04/tc04t001/tc04t001.cpp Changeset: 68ef70c9a921 Author: erikj Date: 2019-06-21 06:33 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/68ef70c9a921 8226538: find-files.gmk gets corrupted if tab completion is used before running make first Reviewed-by: tbell ! make/common/FindTests.gmk ! test/make/TestMake.gmk Changeset: a6411f1e63f3 Author: adinn Date: 2019-06-21 15:16 +0100 URL: https://hg.openjdk.java.net/amber/amber/rev/a6411f1e63f3 8226203: MappedByteBuffer.force method may have no effect on implementation specific map modes Summary: Fix comment for MappedByteBuffer force methods Reviewed-by: alanb ! src/java.base/share/classes/java/nio/MappedByteBuffer.java Changeset: e9d4e0a9c8c7 Author: coleenp Date: 2019-06-21 09:53 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/e9d4e0a9c8c7 8226394: [TESTBUG] vmTestbase/metaspace/flags/maxMetaspaceSize/TestDescription.java fails with java.lang.NoClassDefFoundError Summary: don't use printStackTrace to verify OOM type. Reviewed-by: lfoltan, dholmes ! test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java Changeset: 076f34b82b98 Author: weijun Date: 2019-06-21 23:44 +0800 URL: https://hg.openjdk.java.net/amber/amber/rev/076f34b82b98 8225257: sun/security/tools/keytool/PSS.java timed out Reviewed-by: valeriep - test/jdk/sun/security/tools/keytool/PSS.java + test/jdk/sun/security/tools/keytool/pss/PSS.java + test/jdk/sun/security/tools/keytool/pss/java.base/sun/security/rsa/RSAKeyPairGenerator.java Changeset: e00591da418d Author: erikj Date: 2019-06-21 10:38 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/e00591da418d 8226269: Race in SetupProcessMarkdown Reviewed-by: tbell ! make/common/ProcessMarkdown.gmk Changeset: 97c75e545302 Author: jjg Date: 2019-06-21 11:41 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/97c75e545302 8226592: Fix HTML in table for jdk.zipfs module-info Reviewed-by: bpb, lancea ! src/jdk.zipfs/share/classes/module-info.java Changeset: 179204eb9444 Author: jjg Date: 2019-06-21 12:09 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/179204eb9444 8226593: Fix HTML in com/sun/jdi/doc-files/signature.html Reviewed-by: sspitsyn, lancea ! src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html Changeset: 72bbc930d7b6 Author: jwilhelm Date: 2019-06-22 02:03 +0200 URL: https://hg.openjdk.java.net/amber/amber/rev/72bbc930d7b6 Merge - test/jdk/sun/security/tools/keytool/PSS.java Changeset: c9e362aef472 Author: zgu Date: 2019-06-24 09:51 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/c9e362aef472 8226586: Shenandoah: No need to pre-evacuate roots for degenerated GC Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp Changeset: 73250862f818 Author: michaelm Date: 2019-06-24 15:10 +0100 URL: https://hg.openjdk.java.net/amber/amber/rev/73250862f818 8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException Reviewed-by: chegar, dfuchs ! test/jdk/java/net/MulticastSocket/Promiscuous.java Changeset: 6ca3526c4e25 Author: michaelm Date: 2019-06-24 15:19 +0100 URL: https://hg.openjdk.java.net/amber/amber/rev/6ca3526c4e25 8226683: Remove review suggestion from fix to 8219804 Reviewed-by: chegar ! test/jdk/java/net/MulticastSocket/Promiscuous.java Changeset: aee0d296c0ef Author: zgu Date: 2019-06-24 11:46 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/aee0d296c0ef 8226311: Shenandoah: Concurrent evacuation of OopStorage backed weak roots Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.hpp Changeset: c396e381cfa4 Author: zgu Date: 2019-06-24 14:13 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/c396e381cfa4 8226310: Shenandoah: Concurrent evacuation of CLDG Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp Changeset: ae2e53e379cb Author: coleenp Date: 2019-06-24 16:51 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/ae2e53e379cb 8214822: Move ConcurrentHashTable VALUE parameter to CONFIG Summary: make VALUE parameter be included in CONFIG configuration, also remove BaseConfig Reviewed-by: dholmes, kbarrett ! src/hotspot/share/classfile/stringTable.cpp ! src/hotspot/share/classfile/symbolTable.cpp ! src/hotspot/share/prims/resolvedMethodTable.cpp ! src/hotspot/share/utilities/concurrentHashTable.hpp ! src/hotspot/share/utilities/concurrentHashTable.inline.hpp ! src/hotspot/share/utilities/concurrentHashTableTasks.inline.hpp ! test/hotspot/gtest/utilities/test_concurrentHashtable.cpp Changeset: 80b27dc96ca3 Author: dcubed Date: 2019-06-24 22:38 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/80b27dc96ca3 8226699: [BACKOUT] JDK-8221734 Deoptimize with handshakes Reviewed-by: dholmes, rehn, dlong ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/aot/aotCompiledMethod.cpp ! src/hotspot/share/aot/aotCompiledMethod.hpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/gc/z/zBarrierSetNMethod.cpp ! src/hotspot/share/gc/z/zNMethod.cpp ! src/hotspot/share/jvmci/jvmciEnv.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/prims/jvmtiEventController.cpp ! src/hotspot/share/prims/methodHandles.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/biasedLocking.cpp ! src/hotspot/share/runtime/biasedLocking.hpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/deoptimization.hpp ! src/hotspot/share/runtime/mutex.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vmOperations.cpp ! src/hotspot/share/runtime/vmOperations.hpp ! src/hotspot/share/services/dtraceAttacher.cpp - test/hotspot/jtreg/compiler/codecache/stress/UnexpectedDeoptimizationAllTest.java Changeset: f1e5ddb814b7 Author: serb Date: 2019-06-21 16:20 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/f1e5ddb814b7 8225146: Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html Reviewed-by: aivanov ! src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html Changeset: e17c9a93b505 Author: sspitsyn Date: 2019-06-21 18:20 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/e17c9a93b505 8224555: vmTestbase/nsk/jvmti/scenarios/contention/TC02/tc02t001/TestDescription.java failed Summary: Improve synchronization in the test Reviewed-by: dcubed, amenkov ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/contention/TC02/tc02t001.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/contention/TC02/tc02t001/tc02t001.cpp Changeset: 4d5eabe8d341 Author: sspitsyn Date: 2019-06-22 14:35 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/4d5eabe8d341 8226595: jvmti/scenarios/contention/TC04/tc04t001/TestDescription.java still fails due to wrong number of MonitorContendedEntered events Summary: Fix one more sync issue in the test Reviewed-by: dcubed, amenkov ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/contention/TC04/tc04t001.java Changeset: 00c08fae63e8 Author: mullan Date: 2019-06-24 10:11 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/00c08fae63e8 8180005: Provide specific links in KeyManagerFactory and TrustManagerFactory to the Standard Algorithm Names Specification Reviewed-by: ascarpino ! src/java.base/share/classes/javax/net/ssl/KeyManagerFactory.java ! src/java.base/share/classes/javax/net/ssl/TrustManagerFactory.java Changeset: 1cd4d287839b Author: bobv Date: 2019-06-24 11:49 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/1cd4d287839b 8224502: [TESTBUG] JDK docker test TestSystemMetrics.java fails with access issues and OOM Reviewed-by: sgehwolf, mseledtsov ! test/jdk/ProblemList.txt ! test/jdk/jdk/internal/platform/docker/TestSystemMetrics.java ! test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java Changeset: 1e4bbd6fbb2f Author: bobv Date: 2019-06-24 11:52 -0400 URL: https://hg.openjdk.java.net/amber/amber/rev/1e4bbd6fbb2f 8224506: [TESTBUG] TestDockerMemoryMetrics.java fails with exitValue = 137 Reviewed-by: sgehwolf, mseledtsov ! test/jdk/ProblemList.txt ! test/jdk/jdk/internal/platform/docker/TestDockerMemoryMetrics.java Changeset: fe6c2f0b42be Author: jjg Date: 2019-06-24 13:40 -0700 URL: https://hg.openjdk.java.net/amber/amber/rev/fe6c2f0b42be 8226628: The copyright footer should be enclosed in